Skip to content

Refactor orc boss naming function #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SloaneTribble wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Refactor orc boss naming function #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
86112a0
Refactor orc boss naming function to use arrays instead of switch sta…
SloaneTribble May 11, 2023
4a82f2f
Improve scalability of index calculation functions
SloaneTribble May 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 21 additions & 61 deletions muscle-quest-app/src/app/orc-boss/orc-boss.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,69 +102,29 @@ export class OrcBossComponent {
return boss_name;
} else {
// Generate a random name for the boss
const name_start = Math.floor(Math.random() * 4);
const name_middle = Math.floor(Math.random() * 4);
const name_end = Math.floor(Math.random() * 4);
const name_title = Math.floor(Math.random() * 4);

let name = '';

// switch based off the various options
switch (name_start) {
case 0:
name += 'Ger';
break;
case 1:
name += 'Bo';
break;
case 2:
name += 'Da';
break;
case 3:
name += 'Jor';
break;
}
switch (name_middle) {
case 0:
name += 'bod';
break;
case 1:
name += 'nok';
break;
case 2:
name += 'vik';
break;
case 3:
name += 'jor';
break;
}
switch (name_end) {
case 0:
name += 'bod';
break;
case 1:
name += 'nok';
break;
case 2:
name += 'vik';
break;
case 3:
name += 'jor';
break;
}
switch (name_title) {
case 0:
name += ' the Mighty';
break;
case 1:
name += ' the Fearsome';
break;
case 2:
name += ' the Terrible';
break;
case 3:
name += ' the Warrior';
break;
}
const name_starts = ['Ger', 'Bo', 'Da', 'Jor'];
const name_middles_and_ends = ['bod', 'nok', 'vik', 'jor'];
const name_titles = [
' the Mighty',
' the Fearsome',
' the Terrible',
' the Warrior',
];

const name_start = Math.floor(Math.random() * name_starts.length);
const name_middle = Math.floor(
Math.random() * name_middles_and_ends.length
);
const name_end = Math.floor(Math.random() * name_middles_and_ends.length);
const name_title = Math.floor(Math.random() * name_titles.length);

name += name_starts[name_start];
name += name_middles_and_ends[name_middle];
name += name_middles_and_ends[name_end];
name += name_titles[name_title];
localStorage.setItem('orc-boss-name', name);
return name;
}
Expand Down
2 changes: 1 addition & 1 deletion muscle-quest-app/src/app/sloane-lvl-one/sloane-lvl-one.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ export class SloaneLvlOneComponent {
setBonus() {
type EquippedKey = 'head' | 'chest' | 'hands' | 'feet' | 'weapon';

let user = this.userService.getCurrentUserData();
const user = this.userService.getCurrentUserData();

let dex = 0;
const currentElement = this.elementChoice;
Expand Down