-
Notifications
You must be signed in to change notification settings - Fork 0
Add examples documentation and fix docs build issues #15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
📚 Documentation ReviewSummaryThe ChipFlow documentation is well-organized with clear progressive examples, but has significant command syntax inconsistencies and references to external documentation that doesn't exist in the repository. Issues FoundCritical
Major
Minor
Recommendations
This review was automatically generated by Claude Code |
- Add documentation for chipflow-examples:
- examples/index.rst: Overview of available examples
- examples/getting-started.rst: Setup and first build guide
- examples/minimal.rst: Minimal SoC example documentation
- examples/mcu-soc.rst: MCU SoC example documentation
- Fix documentation build issues:
- Add sphinx_design extension for badge roles
- Add rst_epilog with |required| and |optional| substitutions
- Add chipflow package to autoapi_dirs for complete API docs
- Replace platform-api.rst autodoc directives with static content
(autodoc requires chipflow to be installed)
- Exclude UNFINISHED_IDEAS.md from build
- Reorganize index.rst:
- Add "Getting Started" section with tutorial
- Add "Examples" section
- Rename existing section to "Reference"
- Add CLAUDE.md with project instructions
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This adds a GitHub Actions workflow that: - Triggers on PRs and pushes affecting docs/** or *.md files - Builds the documentation to catch build errors - Runs Claude Code to review documentation for: - Technical accuracy (code examples, command-line examples) - Consistency (terminology, code style) - Flow and organization (logical structure) - Completeness (feature coverage, gaps) - Links and references (cross-references, URLs) - Posts review results as PR comments - Uploads review results as artifacts Requires ANTHROPIC_API_KEY secret to be configured in the repository. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Critical fixes: - Standardize repository naming: example-socs → chipflow-examples - Fix Python version: 3.8 → 3.11+ (matches chipflow-lib requirements) - Update build commands: make → pdm run chipflow (consistent with examples) Major fixes: - Update support channel: Gitter → GitHub Discussions - Fix typo: "reproduable" → "reproducible" - Standardize terminology: "beta" → "alpha program" - Update "Building for Silicon" section to link to examples guide - Fix URLs: build.chipflow.org → build.chipflow.com - Remove broken autoapi/index reference from platform-api.rst 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Disable autoapi_add_toctree_entry to prevent warnings about non-existent chipflow-lib/autoapi/index document - Add post-copy processing to include autoapi-generated indices (chipflow/index and chipflow_lib/index) in the chipflow-lib toctree - This properly integrates the auto-generated API documentation into the navigation while avoiding the toctree reference errors Remaining warnings (18) are from docstring formatting issues in chipflow-lib source code that would need to be fixed upstream. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
Add check in copy_docs.py to skip git checkout when a vendor repository has uncommitted changes or is on a local branch. This prevents losing work-in-progress changes when rebuilding documentation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Fix import from copy_docs module - Simplify platform-api.rst to use autoapi toctree - Add autoapi_ignore for chipflow_lib backward compat shim - Remove duplicate autoapi_dirs entries - Comment out myst_parser (not installed) - Add print statements for debugging sys.path additions 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Use relative path for toctree entry to chipflow-lib/autoapi/chipflow/index - Exclude chipflow-lib/platform-api.rst since we use root level platform-api.rst - Updated comments for clarity 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
3f7553a to
dab75ec
Compare
📖 Documentation Preview✅ Preview is live! Built from commit f4f3c51 |
Summary
Add documentation for chipflow-examples:
examples/index.rst: Overview of available examplesexamples/getting-started.rst: Setup and first build guideexamples/minimal.rst: Minimal SoC example documentationexamples/mcu-soc.rst: MCU SoC example documentationFix documentation build issues:
sphinx_designextension for badge roles (|required|,|optional|)rst_epilogwith substitution definitionschipflowpackage toautoapi_dirsfor complete API docsplatform-api.rstautodoc directives with static content (autodoc requires chipflow to be installed)UNFINISHED_IDEAS.mdfrom buildReorganize
index.rst:Add CI workflow for documentation review with Claude Code:
docs/**or*.mdfilesANTHROPIC_API_KEYsecret to be configuredAdd
CLAUDE.mdwith project instructionsTest plan
pdm run docsANTHROPIC_API_KEYsecret in repository settings to enable CI workflow🤖 Generated with Claude Code