Updates to include Discord without additional deps, make smtp optional#45
Open
phybros wants to merge 1 commit intoChronial:masterfrom
Open
Updates to include Discord without additional deps, make smtp optional#45phybros wants to merge 1 commit intoChronial:masterfrom
phybros wants to merge 1 commit intoChronial:masterfrom
Conversation
Author
|
Hey I know it's been two years but do we think this will get merged? 😅 |
Owner
|
Hey, sry for being so inactive here. I'm still against merging specific notification services directly and would rather see a plugin system: #49 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the ability to send discord messages via webhooks (no new dependencies were added). Configured using a new
[discord]section in the config file (I updated the example file as well).Also made smtp disableable using a new
enabled = falseflag in the[smtp]section since people may not want email at all, and it writes anERRORlog if you don't have the smtp host set up.