Open
Conversation
Author
|
Thoughts on the code? |
Owner
|
Hey, sry for not responding sooner – I didn't yet find time to go over the whole PR. At a quick glance there seem to be some issues with it:
|
OJFord
suggested changes
Feb 25, 2018
| apikey = | ||
|
|
||
| [slack] | ||
| ; set to true to enable Pushbullet notification support |
| from collections import Counter, defaultdict | ||
| from cStringIO import StringIO | ||
|
|
||
| from slackclient import SlackClient |
There was a problem hiding this comment.
No need really to add this dependency for everyone - could instead make it optional and import it within send_slack? (cf.send_email)
There was a problem hiding this comment.
Good point, I don't use the slack client with my other code at this point. I use requests to make slack calls
|
|
||
| if config["logging"]["file"]: | ||
| max_log_size = min(config["logging"]["maxsize"], 0) * 1024 | ||
| max_log_size = max(config["logging"]["maxsize"], 0) * 1024 |
| parser = argparse.ArgumentParser() | ||
| parser.add_argument("-c", "--conf", | ||
| default="snapraid-runner.conf", | ||
| default="snapraid-runner ", |
bumperjeep
approved these changes
Mar 13, 2018
| from collections import Counter, defaultdict | ||
| from cStringIO import StringIO | ||
|
|
||
| from slackclient import SlackClient |
There was a problem hiding this comment.
Good point, I don't use the slack client with my other code at this point. I use requests to make slack calls
Chronial
added
notfication-service
out-of-scope
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added slack and pushbullet