Skip to content

[#H15] Add HW animal #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
IlyaLikhodeev wants to merge 3 commits into
base: main
Choose a base branch
from
Open

[#H15] Add HW animal #50

IlyaLikhodeev wants to merge 3 commits into from

Conversation

@IlyaLikhodeev
Copy link
Collaborator

@IlyaLikhodeev IlyaLikhodeev commented Jun 7, 2022

No description provided.

@IlyaLikhodeev IlyaLikhodeev added the in progress This label indicates that your task is not ready, but you are working on it. label Jun 7, 2022
@IlyaLikhodeev IlyaLikhodeev requested a review from Chudopal June 7, 2022 15:56
@IlyaLikhodeev IlyaLikhodeev added ready for review This label shows, that your task is ready and I can rewiev it. and removed in progress This label indicates that your task is not ready, but you are working on it. labels Jun 10, 2022
Chudopal
Chudopal requested changes Jun 11, 2022
View reviewed changes
Copy link
Owner

@Chudopal Chudopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Переназови ПР, все-таки у тебя не только животные. И убери точку после квадратных скобок, в названии ПРов она не нужна

Shops/car_shop/HomeWork/animal.py



def make_command(self):
Copy link
Owner

@Chudopal Chudopal Jun 11, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Лучше назвать действия животных одинаково, чтобы полиморфизм соблюдать

@Chudopal Chudopal added in progress This label indicates that your task is not ready, but you are working on it. and removed ready for review This label shows, that your task is ready and I can rewiev it. labels Jun 11, 2022
@IlyaLikhodeev IlyaLikhodeev changed the title [#H15].add hw animal [#H15] Add HW animal Jul 3, 2022
@IlyaLikhodeev IlyaLikhodeev added ready for review This label shows, that your task is ready and I can rewiev it. and removed in progress This label indicates that your task is not ready, but you are working on it. labels Jul 3, 2022
Chudopal
Chudopal approved these changes Jul 4, 2022
View reviewed changes
Copy link
Owner

@Chudopal Chudopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Все ок, можно мержить

Chudopal
Chudopal requested changes Jul 8, 2022
View reviewed changes
Copy link
Owner

@Chudopal Chudopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

не забывай про PEP8

Shops/car_shop/HomeWork/animal.py
Comment on lines +88 to +95








Copy link
Owner

@Chudopal Chudopal Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

оставить одну пустую строку

Shops/car_shop/HomeWork/animal.py
Comment on lines +25 to +27



Copy link
Owner

@Chudopal Chudopal Jul 8, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

уменьшить до 2х пустых строк

@Chudopal Chudopal added in progress This label indicates that your task is not ready, but you are working on it. and removed ready for review This label shows, that your task is ready and I can rewiev it. labels Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Chudopal Chudopal Chudopal requested changes

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

in progress This label indicates that your task is not ready, but you are working on it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IlyaLikhodeev @Chudopal