Skip to content

Conversation

@ShedkoV
Copy link
Collaborator

@ShedkoV ShedkoV commented Aug 24, 2022

No description provided.

@ShedkoV ShedkoV added the in progress This label indicates that your task is not ready, but you are working on it. label Aug 24, 2022
@ShedkoV ShedkoV requested a review from Chudopal August 24, 2022 16:15
@ShedkoV ShedkoV added ready for review This label shows, that your task is ready and I can rewiev it. and removed in progress This label indicates that your task is not ready, but you are working on it. labels Aug 30, 2022
Copy link
Owner

@Chudopal Chudopal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Мне нравится в целом, только проследи за офрмлением, чтобы в конце каждого файла была пустая строка и насчет датакласса тоже чеки

Comment on lines +6 to +13
id: str
created_at: str
started_at: str
finished_at: str
title: str
description: str
depends_on: Optional[str] = ''
status: str
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Жене в ПРе оставил замечания по этому классу данных, посмотри их

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Вопрос решён, @mega-yujin дал добро

@Chudopal Chudopal added in progress This label indicates that your task is not ready, but you are working on it. and removed ready for review This label shows, that your task is ready and I can rewiev it. labels Sep 6, 2022
@ShedkoV ShedkoV added ready for review This label shows, that your task is ready and I can rewiev it. and removed in progress This label indicates that your task is not ready, but you are working on it. labels Sep 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready for review This label shows, that your task is ready and I can rewiev it.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants