Эффективность по памяти #5
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| class NodeState: | ||
| """Класс, представляющий состояние узла. Он может быть определен | ||
| в зависимости от структуры данных.""" | ||
| def __init__(self, data: Optional['NodeState'] = None): |
Collaborator
There was a problem hiding this comment.
С питона 3.10 вместо data: Optional['NodeState'] = None можно писать:
data: NodeState | None = None
| :param state: Состояние узла. | ||
| """ | ||
| self.state: Optional[NodeState] = state | ||
| self.children: Dict[int, 'Node'] = {} |
Collaborator
There was a problem hiding this comment.
Также в новых питонах нет необходимости импортировать Dict из typing можно просто dict писать, и типы данных не нужно в кавычках писать
|
|
||
| class PersistentMap(BasePersistent): | ||
| """Персистентный ассоциативный массив. | ||
| """A persistent associative array. |
Collaborator
There was a problem hiding this comment.
Везде была дока на русском а тут почему-то на английском пошла
DimitryPuchkov
requested changes
Dec 17, 2024
|
|
||
| def update_version(self, version): | ||
| """Обновляет текущую версию персистентной структуры данных до указанной. | ||
| def set_version_doubly_linked_list(self, version: int) -> None: |
Collaborator
There was a problem hiding this comment.
Не понятно зачем такой метод в базовом классе, и не правильное название, если это используется только в списке, то нужно этот метод в соответствующем классе прописать и там уже очевидно не нужно будет пояснение в виде _doubly_linked_list.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Улучшенная реализация по памяти всех персиснтентных структур с использованием B-деревьев. Все покрыто тестами и отлажено линтером