Conversation
Integrated Leaflet Routing Machine (OSRM) to visualize routes from the firehouse to each active alarm location on the map, excluding alarms at the firehouse itself. Updated dependencies in monitor.html and added route management logic in map.js, including route clearing and creation functions.
ClarkLiam
commented
Jan 21, 2026
Owner
Author
ClarkLiam
left a comment
ClarkLiam
left a comment
There was a problem hiding this comment.
no extra lines, clean extension
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request integrates Leaflet Routing Machine (OSRM) to display routes from the firehouse to active alarm locations on the map, addressing issue #19. The implementation adds visual route lines showing the fastest path to each alarm, excluding routes to alarms at the firehouse itself.
Changes:
- Added Leaflet Routing Machine library dependency (version 3.2.12) for route visualization
- Implemented route creation and clearing logic for active alarms
- Integrated routing with existing marker update flow to show routes from firehouse to alarm locations
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 6 comments.
| File | Description |
|---|---|
| monitor.html | Added CSS and JavaScript dependencies for Leaflet Routing Machine library |
| src/js/map.js | Added route management functions (createRoute, clearRoutes) and integrated routing into the alarm marker update workflow |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Integrated Leaflet Routing Machine (OSRM) to visualize routes from the firehouse to each active alarm location on the map, excluding alarms at the firehouse itself. Updated dependencies in monitor.html and added route management logic in map.js, including route clearing and creation functions, solving issue #19 and creating more possibilities for future expansion with vehicle tracking