Remove unnecessary explicit conformance to Equatable #30
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that the models in
Order.swiftexplicitly implement the==function to conform toEquatable. This means that each time a model is updated, this method must be updated too, which makes it easy to make a mistake by forgetting to do so. This could be avoided by making all properties inside the models conform toEquatabletoo.Also,
lhs.date.timeIntervalSince(rhs.date) < 1.0comparison wasn't working correctly because for each case whenrhsis later thanlhsit would always return true.This also revealed an error in the Unit Tests when
OrdersWorker.updateOrdermethod wasn't returning the correct order with the updated date in it.Therefore I have:
==methodEquatableupdateOrdermethod insideOrdersWorkerTeststest suite return theOrderobject passed to it inside thecompletionHandlerinstead of the static mock object fromOrdersWorkerTests.testOrders