chore: address remaining feedback of #244 (feat!(insert): RowBinaryWithNamesAndTypes)
#302
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abonander
commented
Sep 22, 2025
abonander
force-pushed
the
ab/insert-metadata
branch
3 times, most recently
from
3a4c5c8 to
f6f4a9e
Compare
This reverts commit b9d3bc1.
invalidate on `with_url`
abonander
force-pushed
the
ab/insert-metadata
branch
from
f6f4a9e to
fbdd340
Compare
…sert-metadata # Conflicts: # tests/it/rbwnat_smoke.rs
and don't error on EPHEMERAL columns
abonander
force-pushed
the
ab/insert-metadata
branch
from
1608227 to
7a56e55
Compare
slvrtrn
previously approved these changes
Oct 2, 2025
| } | ||
|
|
||
| // TODO: what should happen if a column is mentioned multiple times? | ||
| set_columns[col] = true; |
Contributor
There was a problem hiding this comment.
Is it possible?
I tried it with the console client.
SELECT
'a' AS foo,
'b' AS foo
Received exception from server (version 25.6.2):
Code: 179. DB::Exception: Received from localhost:9000. DB::Exception:
Multiple expressions 'b' AS foo and 'a' AS foo for alias foo. In scope SELECT 'a' AS foo, 'b' AS foo. (MULTIPLE_EXPRESSIONS_FOR_ALIAS)
--
INSERT INTO foo (a, a, a) FORMAT Values
Received exception from server (version 25.6.2):
Code: 15. DB::Exception: Received from localhost:9000. DB::Exception:
Column a in table default.foo (e514ca83-9edb-412e-aae0-4ccec2c4ad3d) specified more than once. (DUPLICATE_COLUMN)
slvrtrn
approved these changes
Oct 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The intent of this PR is to address the remaining feedback on #244.
Fixes #295
Fixes #298
Fixes #299
Checklist
Client::clear_cached_metadata()Client::with_url(),Client::with_database()add(reverted)Client::with_metadata_ttl()system.columnsfor more metadatasupport RWBNAT header in mocked data(punting because it requires design work/discussion)Client::with_url()with mocks