feat: implement InsertFormatted
#364
Open
+1,895
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slvrtrn
reviewed
Dec 17, 2025
| /// Any other type of statement may produce incorrect results. | ||
| /// | ||
| /// The statement is not issued until the first call to `.poll_write()`. | ||
| pub fn insert_formatted_with( |
Contributor
There was a problem hiding this comment.
perhaps then we need to deprecate fetch_bytes, replacing it with fetch_formatted_with for consistency
Contributor
Author
There was a problem hiding this comment.
This could just be insert_bytes_with, I'm not particularly attached to the naming. I just tried to come up with something more descriptive.
slvrtrn
reviewed
Dec 17, 2025
|
|
||
| /// Sets timeouts for different operations. | ||
| /// | ||
| /// `send_timeout` restricts time on sending a data chunk to a socket. |
Contributor
There was a problem hiding this comment.
docs CI probably will complain about this without square brackets
Contributor
Author
There was a problem hiding this comment.
This was copied straight from Insert
abonander
force-pushed
the
ab/insert-formatted
branch
from
35a37ab to
20d28ea
Compare
abonander
force-pushed
the
ab/insert-formatted
branch
2 times, most recently
from
77cfc36 to
aa4b220
Compare
abonander
force-pushed
the
ab/insert-formatted
branch
from
aa4b220 to
4495225
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
closes #339
Client::insert_formatted_with()andInsertFormattedfor inserting data in a chosen format with a specified SQL query.I decided to implement
AsyncWriteinstead of usingasync fns which should make this type easier to compose. For example, we can usetokio_util::io::SyncIoBridgeto turn it into blocking I/O for the ADBC driver and directly wrap it in https://docs.rs/arrow-ipc/57.1.0/arrow_ipc/writer/struct.StreamWriter.htmlPotential additions:
Client::insert_formatted(), taking a table name and format nameBytes, bypassing buffer?Insertusing this APIDelete items not relevant to your PR: