Skip to content

Count plugins #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lukemarsden wants to merge 4 commits into
base: clean
Choose a base branch
from
Open

Count plugins #17

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
239a178
Support integer count of plugins in docker cli
May 4, 2015
5d5261e
Add count of plugins in docker info output
May 4, 2015
d676693
single typed
May 4, 2015
a42097a
spelling it right
May 4, 2015
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions api/client/commands.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -514,6 +514,9 @@ func (cli *DockerCli) CmdInfo(args ...string) error {
if remoteInfo.Exists("Images") {
fmt.Fprintf(cli.out, "Images: %d\n", remoteInfo.GetInt("Images"))
}
if remoteInfo.Exists("Plugins") {
fmt.Fprintf(cli.out, "Plugins: %d\n", remoteInfo.GetInt("Plugins"))
}
if remoteInfo.Exists("Driver") {
fmt.Fprintf(cli.out, "Storage Driver: %s\n", remoteInfo.Get("Driver"))
}
Expand Down
2 changes: 2 additions & 0 deletions daemon/info.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@ import (
"github.com/docker/docker/pkg/parsers/kernel"
"github.com/docker/docker/pkg/parsers/operatingsystem"
"github.com/docker/docker/pkg/system"
"github.com/docker/docker/plugins"
"github.com/docker/docker/registry"
"github.com/docker/docker/utils"
)
Expand Down Expand Up @@ -67,6 +68,7 @@ func (daemon *Daemon) CmdInfo(job *engine.Job) engine.Status {
v := &engine.Env{}
v.SetJson("ID", daemon.ID)
v.SetInt("Containers", len(daemon.List()))
v.SetInt("Plugins", plugins.Repo.CountPlugins())
v.SetInt("Images", imgcount)
v.Set("Driver", daemon.GraphDriver().String())
v.SetJson("DriverStatus", daemon.GraphDriver().Status())
Expand Down
6 changes: 6 additions & 0 deletions plugins/repository.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ func NewRepository() *Repository {
}
}

func (repository *Repository) CountPlugins() int {
// TODO: expand this to include other supported types
plugins, _ := repository.GetPlugins("volume")
return len(plugins)
}

func (repository *Repository) RegisterPlugin(addr string) error {
plugin := &Plugin{addr: addr}
resp, err := plugin.handshake()
Expand Down