Add set num to tokens.xml#350
Open
SlightlyCircuitous wants to merge 1 commit intoCockatrice:masterfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a set number attribute (
num) to every token printing that was physically printed in a set. Custom tokens, blog tokens, and tokens only found on Arena don't have set numbers (at least not that I can tell) and so have not received this attribute. I assigned almost all of these nums programmatically, by looking up the UUID on Scryfall. However, A Mysterious Creature, Cyberman, Morph, and Manifest aretype:Creatureand are additionally difficult to search for on Scryfall, so I have done those 15 printings manually.There are two reasons to do this:
Card Infobox; set number is currently always blank for tokens and this would fill those fields inI am currently uncertain what (if anything) to do about tokens that do not have an official set number and open to suggestions, but this PR at least solves the above issues for the majority of the file.