Skip to content

Add set num to tokens.xml#350

Open
SlightlyCircuitous wants to merge 1 commit intoCockatrice:masterfrom
SlightlyCircuitous:patch-3
Open

Add set num to tokens.xml#350
SlightlyCircuitous wants to merge 1 commit intoCockatrice:masterfrom
SlightlyCircuitous:patch-3

Conversation

@SlightlyCircuitous
Copy link
Contributor

This PR adds a set number attribute (num) to every token printing that was physically printed in a set. Custom tokens, blog tokens, and tokens only found on Arena don't have set numbers (at least not that I can tell) and so have not received this attribute. I assigned almost all of these nums programmatically, by looking up the UUID on Scryfall. However, A Mysterious Creature, Cyberman, Morph, and Manifest are type:Creature and are additionally difficult to search for on Scryfall, so I have done those 15 printings manually.

There are two reasons to do this:

  • The client currently lists the set number for cards and tokens in the Card Info box; set number is currently always blank for tokens and this would fill those fields in
  • Lookup by set num was requested in Add UUIDs to the Tokens File #340 (comment) and this provides preliminary XML support in the event this is implemented in the client

I am currently uncertain what (if anything) to do about tokens that do not have an official set number and open to suggestions, but this PR at least solves the above issues for the majority of the file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant