-
Notifications
You must be signed in to change notification settings - Fork 0
Ddb/ssf 8 admin order management frontend #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
amywng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
sam-schu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some initial things I noticed:
- Have you checked with Priya whether we want to display the statuses as we're currently keeping track of them internally, or with the names they have in the Figma?
- Can you check with Priya if "Assignee" should be changed to "Assignees"?
- Can you check with Priya what the page should look like if there's no orders? To me when there's no orders it looks like the page didn't load properly (even though it did)
- If there are no orders, hovering over the right pagination chevron causes it to change color, even though there is only one page
- Can we make it so when you hover over an enabled chevron, the cursor also changes to a pointer?
- Can we cycle through the assignee colors rather than having them be randomly assigned? It looks weird to me when we get the same color twice in a row, and it also feels weird that refreshing the page changes all the colors
amywng
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!!! 😎 🤏 🕶️ 😮💨
ℹ️ Issue
Closes #8
📝 Description
Write a short summary of what you added. Why is it important? Any member of C4C should be able to read this and understand your contribution -- not just your team members.
I followed the Figma for the admin order management frontend page. I needed to add a few things in particular such as a slight adjustment to the backend in order to get the SSF pantry representative (the volunteer the admin assigns to the order). Aside from that, a majority of the ticket was a similar design pattern to the admin donation management page.
✔️ Verification
Verified proper UI according to Figma:
🏕️ (Optional) Future Work / Notes