[SSF-79] Improve Peformance for Log New Donation Form Modal #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dburkhart07
force-pushed
the
ddb/SSF-79-improve-performance-log-new-donation-form
branch
from
3c5bca7 to
3c3e332
Compare
dburkhart07
force-pushed
the
ddb/SSF-79-improve-performance-log-new-donation-form
branch
from
d73a38e to
20b9bbe
Compare
amywng
requested changes
Dec 4, 2025
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
can you change the field in donationItems entity to donationId instead of donation_id, also merge main so i can run it w/o issues
apps/backend/src/donationItems/donationItems.controller.spec.ts
Outdated
Show resolved
Hide resolved
amywng
requested changes
Dec 6, 2025
apps/frontend/src/components/forms/deliveryConfirmationModal.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/src/components/forms/deliveryConfirmationModal.tsx
Outdated
Show resolved
Hide resolved
apps/frontend/src/components/forms/deliveryConfirmationModal.tsx
Outdated
Show resolved
Hide resolved
| totalValue = 0; | ||
|
|
||
| updatedRows.forEach((row) => { | ||
| if (row.numItems && row.ozPerItem && row.valuePerItem) { |
Member
There was a problem hiding this comment.
imo i feel like we shouldn't wait til they're all filled out, but update as any row is changed (also know this isn't part of your ticket but food for thought ig
amywng
requested changes
Dec 6, 2025
apps/backend/src/donationItems/dtos/create-donationItems.dto.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/donationItems/dtos/create-donationItems.dto.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/donationItems/dtos/create-donation-items.dto.ts
Outdated
Show resolved
Hide resolved
apps/backend/src/donationItems/donationItems.controller.spec.ts
Outdated
Show resolved
Hide resolved
amywng
requested changes
Dec 6, 2025
amywng
requested changes
Dec 7, 2025
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
we need to add validation to the form because i was able to submit an invalid entry and it added it to the database but i'm going to say that is whoever does the new form's job
amywng
approved these changes
Dec 8, 2025
Member
amywng
left a comment
amywng
left a comment
There was a problem hiding this comment.
couple small comments. once justin's pr goes in you'll have to fix the status stuff but i'm approving
amywng
reviewed
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #79
📝 Description
✔️ Verification
Ensured only 1 api call was being made via console logs
Successful confirmation of 1 api call being made:
🏕️ (Optional) Future Work / Notes
Still need to write tests for the rest of the controllers, as well as the services. We are holding off on service tests for now though, pending a potential change in how we do testing.