Refactoring for Grace Framework migration to SQLModel #147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PenguinBoi12
had a problem deploying
to
staging
GitHub Actions
Failure
PenguinBoi12
changed the title
PenguinBoi12
had a problem deploying
to
staging
GitHub Actions
Failure
PenguinBoi12
had a problem deploying
to
staging
GitHub Actions
Failure
# Conflicts: # setup.py
PenguinBoi12
force-pushed
the
update-orm
branch
from
f47cb55 to
b7a4545
Compare
PenguinBoi12
had a problem deploying
to
staging
GitHub Actions
Failure
PenguinBoi12
force-pushed
the
update-orm
branch
from
c5dac77 to
ce90a1f
Compare
PenguinBoi12
had a problem deploying
to
staging
GitHub Actions
Failure
PenguinBoi12
force-pushed
the
update-orm
branch
from
2fb3d8c to
6c5a654
Compare
PenguinBoi12
force-pushed
the
update-orm
branch
from
6b30ad1 to
d31d090
Compare
chrisdedman
previously approved these changes
Oct 14, 2025
Collaborator
chrisdedman
left a comment
chrisdedman
left a comment
There was a problem hiding this comment.
Other than the fromatting nit, everything looks good. I don't have any breaking changes after running it locally.
Comment on lines
1
to
+6
| import base64 | ||
| import json | ||
| import zlib | ||
| import requests | ||
| from logging import info, critical | ||
| from logging import critical, info | ||
|
|
||
| import requests |
Collaborator
There was a problem hiding this comment.
nit: Not quit sure why Ruff did ordered them like this. Can you manually move import requests one line and add a blank line between from .. and import ..
Contributor
Author
There was a problem hiding this comment.
Yeah, the formatting will change anyway with #146 which should be properly configured.
PenguinBoi12
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a overall refactor of grace to reflect the changes of Grace Framework's new ORM and Query System.
Code-Society-Lab/grace-framework#10