Skip to content

Conversation

@dakota-crouchelli-navy
Copy link

added name to CONTRIBUTORS.md

Thanks for submitting a pull request! Below are a few things you can do to help us more quickly review your changes.

Checklist

I have…

  • run the application locally (./scripts/serve) and verified that my changes behave as expected.
  • run the build process locally (./scripts/build) and make sure it builds correctly.
  • run the test suite (./scripts/test) and verified that all tests pass.
  • summarized below my changes and noted which issues (if any) this pull request fixes or addresses.
  • thoroughly outlined below the steps necessary to test my changes.
  • attached screenshots illustrating relevant behavior before and after my changes.
  • read, understand, and agree to the terms described in CONTRIBUTING.md.
  • added my name, email address, and copyright date to CONTRIBUTORS.md.

Summary of Changes

This pull request…

  • Adds nawcad-creative-lab/unity-sandbox-assets.json to GitHub releases
  • Adds name to CONTRIBUTORS.md

Testing

To verify the changes proposed in this pull request…

  1. Run scripts/serve and check http://localhost:4000/code.json for a new block describing "NAWCAD CREATIVE Lab - Unity Sandbox Assets"
  2. Run scripts/test and verify the output matches what has been pasted below. It contains errors, but none that relate to the added content.
  3. Check CONTRIBUTORS.md and verify that Dakota Crouchelli's name has been added.
Running ["ScriptCheck", "LinkCheck", "ImageCheck"] on ["./public"] on *.html...


Adding 0 links to the cache...
Removing 1 link from the cache...
Checking 7 external links...
Adding 0 links to the cache...
Removing 0 links from the cache...
Found 0 internal links in the cache...
Ran on 7 files!


- ./public/frequently-asked-questions.html
  *  External link https://dodcio.defense.gov/Portals/0/Documents/Library/SoftwareDev-OpenSource.pdf failed: 403 No error
  *  External link https://dodcio.defense.gov/open-source-software-faq/ failed: 403 No error
  *  External link https://medium.com/@DefenseDigitalService/code-mil-an-open-source-initiative-at-the-pentagon-5ae4986b79bc#.tphs4mxqp failed: 403 No error
  *  External link https://www.defense.gov/Newsroom/Releases/Release/Article/1092364/dod-announces-the-launch-of-codemil-an-experiment-in-open-source/ failed: 403 No error
- ./public/index.html
  *  External link https://dds.mil/ failed: response code 0 means something's wrong.
             It's possible libcurl couldn't connect to the server or perhaps the request timed out.
             Sometimes, making too many requests at once also breaks things.
             Either way, the return message (if any) from the server is: SSL connect error
  *  External link https://www.defense.gov/News/News-Releases/News-Release-View/Article/1092364/dod-announces-the-launch-of-codemil-an-experiment-in-open-source/ failed: 403 No error
- ./public/why-open-source.html
  *  External link https://medium.com/defense-digital-service failed: 403 No error

HTML-Proofer found 7 failures!

Screenshots

code.json Before:

image

code.json After:

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant