Open
Conversation
CodeMinion
approved these changes
Feb 18, 2025
Owner
CodeMinion
left a comment
CodeMinion
left a comment
There was a problem hiding this comment.
Hi @PeterStaev ,
Great catch on the key. Thanks for the fix.
Author
|
Seems this actually fixes #74 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seems the iOS key used in the map differs from the one used for Android and thus the end cut functionality doesn't work under iOS. Here is a reference of the key usage for android:
another_brother/android/src/main/kotlin/com/rouninlabs/another_brother/method/BrotherUtils.kt
Line 52 in 736f231
This PR adjusts the map key that is used in iOS so that it works correctly.
Fixes #74