Skip to content

West Midlands | ITP-Sept-25 | Georgina Rogers | Sprint 3 | Fetch/Programmer Humour #352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zilinskyte wants to merge 5 commits into
base: main
Choose a base branch
from
Open

West Midlands | ITP-Sept-25 | Georgina Rogers | Sprint 3 | Fetch/Programmer Humour #352

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
5199f96
html and js functioning
zilinskyte Dec 12, 2025
df159df
basic styling implemented
zilinskyte Dec 12, 2025
703824c
accessibility features added to help screen readers
zilinskyte Dec 12, 2025
693adcf
formatting consistency improved, max-width added to prevent img stret…
zilinskyte Dec 12, 2025
47e4bf6
replaced hardcoded URL with constant and improved error handling with…
zilinskyte Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions fetch/programmer-humour/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
<!DOCTYPE html>
<html lang="en">
<head>
<meta charset="UTF-8" />
<meta name="viewport" content="width=device-width, initial-scale=1.0" />
<title>XKCD Latest Comic</title>
<link rel="stylesheet" href="styles.css" />
</head>
<body>
<main>
<h1>Latest XKCD Comic</h1>
<div id="comic-container" aria-live="polite">
Copy link

@eliza-an eliza-an Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aria-live="polite"
Very well done here. This is a really good use of an accessibility feature and just forward-thinking in general. I wouldn't have thought to use it here for this assignment but it's definitely a useful spot to put it. Well done!

<p class="loading">Loading…</p>
</div>
</main>
<script src="script.js"></script>
</body>
</html>
33 changes: 33 additions & 0 deletions fetch/programmer-humour/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
const API_URL = "https://xkcd.now.sh/?comic=latest";
Copy link

@eliza-an eliza-an Dec 22, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very well done here for exporting this to a variable. It's aways helpful to the reviewer!


async function getLatestComic() {
const container = document.getElementById("comic-container");

try {
const response = await fetch(API_URL);

if (!response.ok) {
throw new Error(`HTTP error: ${response.status}`);
}

const data = await response.json();
console.log(data);

if (!data.img) {
throw new Error("API did not return an image");
}

container.innerHTML = "";

const img = document.createElement("img");
img.src = data.img;
img.alt = data.alt || data.title || "XKCD comic";

container.appendChild(img);
} catch (error) {
console.error("Fetch error:", error);
container.innerHTML = `<p>Could not load the comic. Please try again later.</p>`;
}
}

getLatestComic();
25 changes: 25 additions & 0 deletions fetch/programmer-humour/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
body {
font-family: Arial, sans-serif;
background: #f4f4f4;
margin: 0;
padding: 20px;
line-height: 1.6;
}

h1 {
text-align: center;
}

#comic-container {
display: flex;
flex-direction: column;
align-items: center;
max-width: 900px;
margin: 20px auto;
}

#comic-container img {
max-width: 100%;
border: 2px solid #333;
border-radius: 8px;
}