generated from CodeYourFuture/Module-Template
-
-
Notifications
You must be signed in to change notification settings - Fork 160
Manchester | 25-ITP-Sep | Mahtem T. Mengstu | Sprint 2 | Book_library #353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Mahtem
wants to merge
5
commits into
CodeYourFuture:main
Choose a base branch
from
Mahtem:Book_library
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
9198e90
Book Library bugs fixed and Book Library working normal.
Mahtem 7fe03c6
Bugs fixed
Mahtem eda7bcc
Book Library script updated.
Mahtem cb7521d
Modifications regarding input preprocessing table rendering and descr…
Mahtem ee1ce99
index.hmtl modified to handle ES modules
Mahtem File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| { | ||
| // Use IntelliSense to learn about possible attributes. | ||
| // Hover to view descriptions of existing attributes. | ||
| // For more information, visit: https://go.microsoft.com/fwlink/?linkid=830387 | ||
| "version": "0.2.0", | ||
| "configurations": [ | ||
| { | ||
| "type": "chrome", | ||
| "request": "launch", | ||
| "name": "Launch Chrome against localhost", | ||
| "url": "http://localhost:8080", | ||
| "webRoot": "${workspaceFolder}" | ||
| } | ||
| ] | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,103 +1,115 @@ | ||
| let myLibrary = []; | ||
| // script.js (module) | ||
|
|
||
| window.addEventListener("load", function (e) { | ||
| populateStorage(); | ||
| render(); | ||
| }); | ||
| export {}; | ||
|
|
||
| function populateStorage() { | ||
| if (myLibrary.length == 0) { | ||
| let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true); | ||
| let book2 = new Book( | ||
| "The Old Man and the Sea", | ||
| "Ernest Hemingway", | ||
| "127", | ||
| true | ||
| ); | ||
| myLibrary.push(book1); | ||
| myLibrary.push(book2); | ||
| render(); | ||
| // Library array | ||
| const myLibrary = []; | ||
|
|
||
| // Book constructor | ||
| class Book { | ||
| constructor(title, author, pages, read) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.read = read; | ||
| } | ||
| } | ||
|
|
||
| const title = document.getElementById("title"); | ||
| const author = document.getElementById("author"); | ||
| const pages = document.getElementById("pages"); | ||
| const check = document.getElementById("check"); | ||
| // Default books | ||
| const defaultBooks = [ | ||
| new Book("Robinson Crusoe", "Daniel Defoe", 252, true), | ||
| new Book("The Old Man and the Sea", "Ernest Hemingway", 127, true), | ||
| ]; | ||
|
|
||
| // DOM references | ||
| const titleInput = document.getElementById("title"); | ||
| const authorInput = document.getElementById("author"); | ||
| const pagesInput = document.getElementById("pages"); | ||
| const readCheckbox = document.getElementById("check"); | ||
| const submitBtn = document.getElementById("submitBtn"); | ||
| const table = document.getElementById("display"); | ||
|
|
||
| // On page load: add default books | ||
|
|
||
| window.addEventListener("DOMContentLoaded", () => { | ||
| if (myLibrary.length === 0) { | ||
| myLibrary.push(...defaultBooks); | ||
| } | ||
| render(); | ||
| }); | ||
|
|
||
| // Submit listener | ||
| submitBtn.addEventListener("click", submit); | ||
|
|
||
| //check the right input from forms and if its ok -> add the new book (object in array) | ||
| //via Book function and start render function | ||
| // Submit function | ||
| function submit() { | ||
| if ( | ||
| title.value == null || | ||
| title.value == "" || | ||
| pages.value == null || | ||
| pages.value == "" | ||
| ) { | ||
| const titleVal = titleInput.value.trim(); | ||
| const authorVal = authorInput.value.trim(); | ||
| const pagesVal = pagesInput.value.trim(); | ||
| const readVal = readCheckbox.checked; | ||
|
|
||
| if (!titleVal || !authorVal || !pagesVal) { | ||
| alert("Please fill all fields!"); | ||
| return false; | ||
| } else { | ||
| let book = new Book(title.value, title.value, pages.value, check.checked); | ||
| library.push(book); | ||
| render(); | ||
| return; | ||
| } | ||
|
|
||
| const pagesNum = Number(pagesVal); | ||
| if (!Number.isInteger(pagesNum) || pagesNum < 1) { | ||
| alert("Pages must be an integer greater than or equal to 1!"); | ||
| return; | ||
| } | ||
| } | ||
|
|
||
| function Book(title, author, pages, check) { | ||
| this.title = title; | ||
| this.author = author; | ||
| this.pages = pages; | ||
| this.check = check; | ||
| myLibrary.push(new Book(titleVal, authorVal, pagesNum, readVal)); | ||
|
|
||
| titleInput.value = ""; | ||
| authorInput.value = ""; | ||
| pagesInput.value = ""; | ||
| readCheckbox.checked = false; | ||
|
|
||
| render(); | ||
| } | ||
|
|
||
| // Render function | ||
| function render() { | ||
| let table = document.getElementById("display"); | ||
| let rowsNumber = table.rows.length; | ||
| //delete old table | ||
| for (let n = rowsNumber - 1; n > 0; n-- { | ||
| table.deleteRow(n); | ||
| } | ||
| //insert updated row and cells | ||
| let length = myLibrary.length; | ||
| for (let i = 0; i < length; i++) { | ||
| let row = table.insertRow(1); | ||
| let titleCell = row.insertCell(0); | ||
| let authorCell = row.insertCell(1); | ||
| let pagesCell = row.insertCell(2); | ||
| let wasReadCell = row.insertCell(3); | ||
| let deleteCell = row.insertCell(4); | ||
| titleCell.innerHTML = myLibrary[i].title; | ||
| authorCell.innerHTML = myLibrary[i].author; | ||
| pagesCell.innerHTML = myLibrary[i].pages; | ||
|
|
||
| //add and wait for action for read/unread button | ||
| let changeBut = document.createElement("button"); | ||
| changeBut.id = i; | ||
| changeBut.className = "btn btn-success"; | ||
| wasReadCell.appendChild(changeBut); | ||
| let readStatus = ""; | ||
| if (myLibrary[i].check == false) { | ||
| readStatus = "Yes"; | ||
| } else { | ||
| readStatus = "No"; | ||
| } | ||
| changeBut.innerText = readStatus; | ||
|
|
||
| changeBut.addEventListener("click", function () { | ||
| myLibrary[i].check = !myLibrary[i].check; | ||
| const tbody = table.tBodies[0]; | ||
|
|
||
|
|
||
| tbody.innerHTML = ""; | ||
|
|
||
| myLibrary.forEach((book, index) => { | ||
| const row = tbody.insertRow(); | ||
|
|
||
| row.insertCell(0).textContent = book.title; | ||
| row.insertCell(1).textContent = book.author; | ||
| row.insertCell(2).textContent = book.pages; | ||
|
|
||
| // Read button | ||
| const readCell = row.insertCell(3); | ||
| const readBtn = document.createElement("button"); | ||
| readBtn.className = "btn btn-success"; | ||
| readBtn.textContent = book.read ? "Yes" : "No"; | ||
| readBtn.addEventListener("click", () => { | ||
| book.read = !book.read; | ||
| render(); | ||
| }); | ||
| readCell.appendChild(readBtn); | ||
|
|
||
| //add delete button to every row and render again | ||
| let delButton = document.createElement("button"); | ||
| delBut.id = i + 5; | ||
| deleteCell.appendChild(delBut); | ||
| delBut.className = "btn btn-warning"; | ||
| delBut.innerHTML = "Delete"; | ||
| delBut.addEventListener("clicks", function () { | ||
| alert(`You've deleted title: ${myLibrary[i].title}`); | ||
| myLibrary.splice(i, 1); | ||
| render(); | ||
| // Delete button | ||
| const deleteCell = row.insertCell(4); | ||
| const deleteBtn = document.createElement("button"); | ||
| deleteBtn.className = "btn btn-warning"; | ||
| deleteBtn.textContent = "Delete"; | ||
| deleteBtn.addEventListener("click", () => { | ||
| if (confirm(`Are you sure you want to delete "${book.title}"?`)) { | ||
| myLibrary.splice(index, 1); | ||
| render(); | ||
| alert("Book deleted successfully!"); | ||
| } | ||
| }); | ||
| } | ||
| deleteCell.appendChild(deleteBtn); | ||
| }); | ||
| } | ||
|
|
||
|
|
||
| // Modifications regarding input preprocessing table rendering and descriptive | ||
| // names have been made. |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
JSON != JS. A JSON string containing JS-style comments is considered invalid.
Better to use
.gitignoreto exclude non-essential configuration files from being added to a repo.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you, I will see what it really is. It happened accidentally.