West Midlands | 25-ITP-Sep | Baba Yusuf | Sprint 3 | Refactoring-dead-code #359
Conversation
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above. |
Baba05206
changed the title
Baba05206
added
📅 Sprint 3
eliza-an
left a comment
eliza-an
left a comment
There was a problem hiding this comment.
Well done, this looks good. Just remember that deleting and commenting out is not the same thing and would cause issues in a real codebase. As for the rest of the assignment. It looks great! well done!
|
|
||
| function sayHello(greeting, name) { | ||
| const greetingStr = greeting + ", " + name + "!"; | ||
| // const greetingStr = greeting + ", " + name + "!"; |
There was a problem hiding this comment.
Well done for doing this correctly! But the instructions said to remove the code and you commented it out! This is important, because comments taks up space in your codebase, so commenting out and deleting are not the same thing! Make sure to delete them next time :)
| // Find the instances of unreachable and redundant code - remove them! | ||
|
|
||
| let testName = "Jerry"; | ||
| const greeting = "hello"; |
There was a problem hiding this comment.
This initial Jerry name is also never used is it?
| //console.log(greetingStr); | ||
| } | ||
|
|
||
| testName = "Aman"; |
There was a problem hiding this comment.
that comment at the bottom on line 16 is also redundant!
eliza-an
added
Reviewed
2 participants
Learners, PR Template
Self checklist
Changelist
Commented out the dead codes in exercises 1 & 2
Questions