Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 17 additions & 20 deletions debugging/book-library/index.html
Original file line number Diff line number Diff line change
@@ -1,20 +1,19 @@
<!DOCTYPE html>
<html>
<html lang="en">
<head>
<title> </title>
<title> Book Library App</title>
<meta name="viewport" content="width=device-width, initial-scale=1.0" >
<meta
charset="utf-8"
name="viewport"
content="width=device-width, initial-scale=1.0"
/>
>
<script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script>
<script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script>
<script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script>
<link
rel="stylesheet"
href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"
/>
<link rel="stylesheet" type="text/css" href="style.css" />
>
<link rel="stylesheet" type="text/css" href="style.css" >
</head>

<body>
Expand All @@ -31,42 +30,40 @@ <h1>Library</h1>
<div class="form-group">
<label for="title">Title:</label>
<input
type="title"
class="form-control"
id="title"
type="text"
class="form-control title"
name="title"
required
/>
<label for="author">Author: </label>
<input
type="author"
class="form-control"
id="author"
type="text"
class="form-control author"
name="author"
required
/>
<label for="pages">Pages:</label>
<input
type="number"
class="form-control"
id="pages"
class="form-control pages"
name="pages"
min = "1"
max = "1000"
required
/>
<label class="form-check-label">
<input
type="checkbox"
class="form-check-input"
id="check"
class="form-check-input check"
value=""
/>Read
</label>
<input
type="submit"
value="Submit"
class="btn btn-primary"
onclick="submit();"
/>
id = "submitButton"
></input>
</div>
</div>

Expand All @@ -91,6 +88,6 @@ <h1>Library</h1>
</tbody>
</table>

<script src="script.js"></script>
<script src="./script.js" type="module"></script>
</body>
</html>
10 changes: 5 additions & 5 deletions debugging/book-library/readme.md
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ My website should be able to:

## Bugs to be fixed

1. Website loads but doesn't show any books
2. Error in console when you try to add a book
3. It uses the title name as the author name
4. Delete button is broken
5. When I add a book that I say I've read - it saves the wrong answer
1. Website loads but doesn't show any books +
2. Error in console when you try to add a book +
3. It uses the title name as the author name +
4. Delete button is broken +
5. When I add a book that I say I've read - it saves the wrong answer +

I think there are other some other small bugs in my code...but I'm lazy so I can't fix them all.

Expand Down
95 changes: 54 additions & 41 deletions debugging/book-library/script.js
Original file line number Diff line number Diff line change
Expand Up @@ -2,16 +2,15 @@ let myLibrary = [];

window.addEventListener("load", function (e) {
populateStorage();
render();
});

function populateStorage() {
if (myLibrary.length == 0) {
let book1 = new Book("Robison Crusoe", "Daniel Defoe", "252", true);
let book1 = new Book("Robison Crusoe", "Daniel Defoe", 252, true);
let book2 = new Book(
"The Old Man and the Sea",
"Ernest Hemingway",
"127",
127,
true
);
myLibrary.push(book1);
Expand All @@ -20,29 +19,44 @@ function populateStorage() {
}
}

const title = document.getElementById("title");
const author = document.getElementById("author");
const pages = document.getElementById("pages");
const check = document.getElementById("check");
const titleElem = document.querySelector(".title");
const authorElem = document.querySelector(".author");
const pagesElem = document.querySelector(".pages");
const checkBox = document.querySelector(".check");

//check the right input from forms and if its ok -> add the new book (object in array)
//via Book function and start render function
function submit() {
if (
title.value == null ||
title.value == "" ||
pages.value == null ||
pages.value == ""
export function submit() {
const bookTitle = titleElem.value.trim();
const bookAuthor = authorElem.value.trim();
const bookPages = Number(pagesElem.value);

if (!Number.isInteger(bookPages)){
alert("Pages must be an integer !");
return false;
}
else if (
bookTitle == "" ||
bookAuthor == "" ||
bookPages <= 0
) {
alert("Please fill all fields!");
return false;
} else {
let book = new Book(title.value, title.value, pages.value, check.checked);
library.push(book);
let book = new Book(bookTitle, bookAuthor, bookPages, checkBox.checked);
myLibrary.push(book);
render();
titleElem.value = "";
authorElem.value = "";
pagesElem.value = "";
checkBox.checked = false;
}
}

document.querySelector('#submitButton').addEventListener('click', () => {
submit();
})

function Book(title, author, pages, check) {
this.title = title;
this.author = author;
Expand All @@ -52,52 +66,51 @@ function Book(title, author, pages, check) {

function render() {
let table = document.getElementById("display");
let rowsNumber = table.rows.length;
//delete old table
for (let n = rowsNumber - 1; n > 0; n-- {
table.deleteRow(n);
}
let tableBody = document.querySelector('tbody');

tableBody.innerHTML = "";

//insert updated row and cells
let length = myLibrary.length;
for (let i = 0; i < length; i++) {
let row = table.insertRow(1);
let row = tableBody.insertRow(0);
let titleCell = row.insertCell(0);
let authorCell = row.insertCell(1);
let pagesCell = row.insertCell(2);
let wasReadCell = row.insertCell(3);
let deleteCell = row.insertCell(4);
titleCell.innerHTML = myLibrary[i].title;
authorCell.innerHTML = myLibrary[i].author;
pagesCell.innerHTML = myLibrary[i].pages;
titleCell.innerText = myLibrary[i].title;
authorCell.innerText = myLibrary[i].author;
pagesCell.innerText = myLibrary[i].pages;

//add and wait for action for read/unread button
let changeBut = document.createElement("button");
changeBut.id = i;
changeBut.className = "btn btn-success";
wasReadCell.appendChild(changeBut);
let changeButton = document.createElement("button");
changeButton.id = i;
changeButton.className = "btn btn-success";
wasReadCell.appendChild(changeButton);
let readStatus = "";
if (myLibrary[i].check == false) {
readStatus = "Yes";
} else {
readStatus = "No";
}
changeBut.innerText = readStatus;
readStatus = myLibrary[i].check ? "yes":"no";

changeButton.innerText = readStatus;

changeBut.addEventListener("click", function () {
changeButton.addEventListener("click", function () {
myLibrary[i].check = !myLibrary[i].check;
render();
});

//add delete button to every row and render again
let delButton = document.createElement("button");
delBut.id = i + 5;
deleteCell.appendChild(delBut);
delBut.className = "btn btn-warning";
delBut.innerHTML = "Delete";
delBut.addEventListener("clicks", function () {
alert(`You've deleted title: ${myLibrary[i].title}`);
delButton.id = i + 5;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Lines 86, 104:
    • Are the values assigned to these id attributes unique?
    • Is there any need to assign an id attribute to either buttons?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does your emoji mean?

deleteCell.appendChild(delButton);
delButton.className = "btn btn-warning";
delButton.innerText = "Delete";
delButton.addEventListener("click", function () {
const deletedTitle = myLibrary[i].title;
myLibrary.splice(i, 1);
render();
setTimeout(() => {
alert(`You've deleted title: ${deletedTitle}`);
}, 0)
});
}
}
2 changes: 1 addition & 1 deletion debugging/book-library/style.css
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
.form-group {
width: 400px;
height: 300px;
align-self: left;
align-self: start;
padding-left: 20px;
}

Expand Down