Skip to content

Conversation

@Della-Bella
Copy link

@Della-Bella Della-Bella commented Dec 17, 2025

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
Changelist

PR: Fix bugs and improve adding books

What was done:

Fixed errors that stopped books from showing on page load

Fixed issues when adding a new book

Corrected author and read status values

Fixed the delete button

Cleared the form after a book is added

Prevented adding the same book twice

Result: the app now works as expected and is easier to use when adding books.

@Della-Bella Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 17, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 17, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Della-Bella Della-Bella changed the title London | 25-ITP-May | Gislaine Della Bella | Sprint 2 | Book Libray London | 25-ITP-May | Gislaine Della Bella | Sprint 2 | Debugging Book Libray Dec 17, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Della-Bella Della-Bella changed the title London | 25-ITP-May | Gislaine Della Bella | Sprint 2 | Debugging Book Libray London | 25-ITP-May | Gislaine Della Bella | Sprint 2 | Book-Libray-25 Dec 17, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Della-Bella Della-Bella changed the title London | 25-ITP-May | Gislaine Della Bella | Sprint 2 | Book-Libray-25 London | 25-ITP-May | Gislaine Della Bella | Sprint 2 | Book libray Dec 17, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Della-Bella Della-Bella added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 17, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@github-actions github-actions bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Dec 17, 2025
Copy link
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Doing so can help me speed up the review process. Thanks.

@cjyuan cjyuan added the Reviewed Volunteer to add when completing a review with trainee action still to take. label Dec 18, 2025
@github-actions
Copy link

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

If this PR needs reviewed, please add the 'Needs Review' label to this PR after you have resolved the issues listed above.

@Della-Bella
Copy link
Author

Hi [cjyuan,
I always get this error in my PR I don't know what I'm doing wrong.

thank you

@cjyuan
Copy link
Contributor

cjyuan commented Dec 19, 2025

Beginning the September 2025 cohort, CYF added a bot to check the PR title and PR description to ensure they meet certain requirements:

  • PR title is specified in a specific format
  • Self-checklist is properly checked
  • The placeholder text in the "Changelist" section is replaced
  • The placeholder text in the "Questions" section is replaced or deleted (if you do no have any question)

You can find the relevant info in this PR Guideline.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants