Glasgow | 25-ITP-Sept | Shreef Ibrahim | Sprint 2 | Book Library #366
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shreefAhmedM
changed the title
shreefAhmedM
added
the
Needs Review
shreefAhmedM
changed the title
shreefAhmedM
changed the title
cjyuan
reviewed
Dec 18, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
-
Can you check if any of this general feedback can help you further improve your code?
https://github.com/cjyuan/Module-Data-Flows/blob/book-library-feedback/debugging/book-library/feedback.md -
Can you also improved the indentation in
script.js?
Doing so can help me speed up the review process. Thanks.
cjyuan
added
Reviewed
shreefAhmedM
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
shreefAhmedM
added
the
Needs Review
This comment has been minimized.
This comment has been minimized.
github-actions
bot
removed
the
Needs Review
This comment has been minimized.
This comment has been minimized.
2 similar comments
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Author
i have updated the code |
shreefAhmedM
added
the
Needs Review
cjyuan
reviewed
Dec 19, 2025
Contributor
cjyuan
left a comment
cjyuan
left a comment
There was a problem hiding this comment.
The input validation can still use some improvement. Everything else looks good.
debugging/book-library/script.js
Outdated
Comment on lines
42
to
45
| if (isNaN(Number(pages)) || Number(pages) <= 0) { | ||
| showError("Pages must be a positive number."); | ||
| return; | ||
| } |
Contributor
There was a problem hiding this comment.
-
Why not stored the converted number to a variable first to avoid unnecessary conversions?
-
Some invalid "number of pages" can still pass this check. Can you strengthen the check?
cjyuan
removed
the
Needs Review
shreefAhmedM
added
Complete
shreefAhmedM
added
the
Needs Review
Contributor
|
Looks good! |
cjyuan
added
Complete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Learners, PR Template
Self checklist
Changelist
PR: Fix bugs and improve adding books
What was done:
Fixed errors that stopped books from showing on page load
Fixed issues when adding a new book
Corrected author and read status values