Skip to content

Conversation

@Keenan-creator
Copy link

@Keenan-creator Keenan-creator commented May 10, 2025

Learners, PR Template

Self checklist

  • I have committed my files one by one, on purpose, and for a reason
  • I have titled my PR with REGION | COHORT_NAME | FIRST_NAME LAST_NAME | PROJ_NAME
  • I have tested my changes
  • My changes follow the style guide
  • My changes meet the requirements of this task

Changelist

Translated requirements into web code
Validated user input with HTML form validations

Briefly explain your PR.

Updated article
Updated the header and footer
Created a form with user inputs adding email, to select t-shirt colours and sizes.

Questions

Ask any questions you have for your reviewer.

@netlify
Copy link

netlify bot commented May 10, 2025

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 1c40083
🔍 Latest deploy log https://app.netlify.com/sites/cyf-onboarding-module/deploys/681fae8d868e620008568580
😎 Deploy Preview https://deploy-preview-418--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 96 (🔴 down 4 from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

@Keenan-creator Keenan-creator added 👀 Review Requirements 📅 Sprint 1 Assigned during Sprint 1 of this module 🦔 Size Tiny Less than 30 minutes Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 10, 2025
@Keenan-creator Keenan-creator moved this to 👀 In review in Coursework Planner Board May 10, 2025
@SallyMcGrath SallyMcGrath removed the 📅 Sprint 1 Assigned during Sprint 1 of this module label May 15, 2025
@Waldo-Strydom
Copy link

Well done.

@Waldo-Strydom Waldo-Strydom added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed 👀 Review Requirements Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 16, 2025
@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Wrong number of parts separated by |s

@github-actions
Copy link

Your PR's title isn't in the expected format.

Please check its title is in the correct format, and update it.

Reason: Wrong number of parts separated by |s

@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Coursework Planner Board Sep 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Reviewed Volunteer to add when completing a review with trainee action still to take. 🦔 Size Tiny Less than 30 minutes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants