London | 25-ITP-September | Carlos Abreu | Sprint 1 | Wireframe #867
Conversation
|
Your PR couldn't be matched to an assignment in this module. Please check its title is in the correct format, and that you only have one PR per assignment. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
✅ Deploy Preview for cyf-onboarding-module ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
carlosyabreu
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
carlosyabreu
added
the
Needs Review
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. |
jenny-alexander
added
Review in progress
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
jenny-alexander
left a comment
jenny-alexander
left a comment
There was a problem hiding this comment.
@carlosyabreu I can see that you put good effort into your first iteration of this exercise requirements. However, it's missing quite a few exercise requirements.
Have a look at the comments I left for you!
| <h2>What is the purpose of a wireframe?</h2> | ||
| <p>A wireframe is a simple blueprint of a webpage or app. It focuses on structure and layout, showing where elements like images, text, and buttons will go before visual design begins. | ||
| </p> | ||
| <a href="https://wireframe.cc/" target="_blank">Read More</a> |
There was a problem hiding this comment.
I recommend changing this link to an article explaining why wireframes are useful. This link brings me to an application where I can build a wireframe.
|
|
||
| <footer> | ||
| <p> | ||
| This is the default, provided code and no changes have been made yet. |
There was a problem hiding this comment.
Can you review the footer requirements for this exercise? It says:
"The page footer is fixed to the bottom of the viewport."
| <div class="branch"> | ||
| <section class="article"> | ||
| <article> | ||
| <img src="git-branch.png" alt="Git branch illustration"> |
There was a problem hiding this comment.
Can you try to make the image a bit smaller? Right now, the image is quite large and blurry.
| <a href="">Read more</a> | ||
| </article> | ||
| <div class="top"> | ||
| <section class="article"> |
There was a problem hiding this comment.
Can you review the exercise requirements? I don't see 'placeholder' as one of the articles that should be displayed in your webpage.
| </section> | ||
| </div> | ||
|
|
||
| <div class="top"> |
There was a problem hiding this comment.
Can you review the exercise requirements? I don't see 'placeholder' as one of the articles that should be displayed in your webpage.
jenny-alexander
added
Reviewed
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
1 similar comment
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
carlosyabreu
changed the title
|
Your PR description contained template fields which weren't filled in. Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed. If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed). |
|
@jenny-alexander P.S.: |
2 participants
Learners, PR Template
Self checklist
Changelist
This PR was built on feature/wireframe branch from wireframe main branch I've forked and should be merged into main branch of the original CYF project.
Questions
I've update the code and hopefully it's working normally now and be approved.
According to 1 reviewer even pushing the code as I did a few hours ago today but need to fill out this part for the code to pass the automated validate_pr_metadata test.
If not please let me know ASAP as I'm a bit delayed.
Thank you for your understanding.