London | 25-ITP-September | Carlos Abreu | Sprint 2 | Form Controls

[carlosyabreu]

Learners, PR Template

Self checklist

• I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
• My changes meet the requirements of the task
• I have tested my changes
• My changes follow the style guide

Changelist

Briefly explain your PR.

Customer form created for selling T-shirt.

Questions

[netlify]

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	282facf
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e5797dded4f100081d96a8
😎 Deploy Preview	https://deploy-preview-878--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

---

To edit notification comments on pull requests, go to your Netlify project configuration.

[github-actions]

Your PR's title isn't in the expected format.

Please check the expected title format, and update yours to match.

Reason: Wrong number of parts separated by |s

[github-actions]

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[github-actions]

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[LonMcGregor]

Did you mean to make changes to the wireframe file? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the sprint task directory. If you can fix that, I can mark this pr as complete

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[github-actions]

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

[carlosyabreu]

Did you mean to make changes to the wireframe file? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the sprint task directory. If you can fix that, I can mark this pr as complete

[carlosyabreu]

Did you mean to make changes to the wireframe file? We try to keep pull requests specific to just the files in the feature we are changing - for this, everything within the sprint task directory. If you can fix that, I can mark this pr as complete

No, this PR is about form control assignment.
About wireframe assignment there is another PR for it.

[LonMcGregor]

Hi @carlosyabreu , Could you please re-open this PR as it is not finished yet. Committing only specific files is an important part of the git pull request workflow, and it would be good to get practice in how you revert unwanted changes.

[carlosyabreu]

@LonMcGregor
I deleted the repo which deleted the PR.
After that I create a new repo and opened new PR as well and it was a mess with merging local feature/form-controls into local main and push it to main GitHub branch. That was wrong again. I delete that repo and it was a 2nd time.
And create this new repo (3rd time) one.
Please this is the PR of a repo I want to be reviewed.
Thank you.

P.S.:
The link for the new PR is here:
#907