West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 2 | Form Controls #879

MohammedNaru · 2025-10-01T15:40:35Z

Pull Request Form Controls

Self checklist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide

Changelist

I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
My changes meet the requirements of the task
I have tested my changes
My changes follow the style guide
Changelist
I have created a webpage according to the Form control task

Questions

No questions.

netlify · 2025-10-01T15:40:40Z

✅ Deploy Preview for cyf-onboarding-module ready!

Name	Link
🔨 Latest commit	`d39194b`
🔍 Latest deploy log	https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e15223d5e08800091dd6d5
😎 Deploy Preview	https://deploy-preview-879--cyf-onboarding-module.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	2 paths audited Performance: 100 (no change from production) Accessibility: 100 (no change from production) Best Practices: 100 (no change from production) SEO: 86 (no change from production) PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

cjyuan · 2025-10-01T16:59:35Z

Instead of adding your files in the top-level folder, you should modify Form-Controls/index.html (the file in Form-Controls folder).
You should not be using CSS in this exercise (as specified in Form-Controls/README.md). So you can delete the file 'Style.css` from your branch.

Please note that filenames are case sensitive. Index.html and index.html are treated as two different names.

Can you delete the two files you added, and update Form-Controls/index.html accordingly?

github-actions · 2025-10-01T17:02:22Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

cjyuan · 2025-10-01T17:09:07Z

The text in the PR description is in written in Markdown.
 is a HTML comment. If you are removing the comment from the template, you should delete the .

I have restored part of the PR description from the PR template. Can you edit them and use Markdown to properly check the boxes?

Note:
You can use Markdown syntax, along with some additional HTML tags, to format your writing on GitHub,
in places like repository READMEs and comments on pull requests and issues.

To learn how to write in Markdown, embed image, tag users, and other advanced features,
visit GitHub Docs - Basic writing and formatting syntax.

cjyuan · 2025-10-01T17:19:29Z

After you have fixed your branch and PR description, please check out this general guide to see if you can further improve your work on your own, which in turn can help speed up the review process.

MohammedNaru · 2025-10-02T20:59:44Z

I have now updated following the guidelines and removing CSS file

cjyuan · 2025-10-03T02:45:33Z

If you clicked the "Files changed" tab in your PR (see pic), you can see all the modified files on this branch, but not all of them
are part of this exercise. Can you keep this branch clean byremoving the files that are not part of this "Form-Controls" exercise?

Your code is well-written, but it includes input elements that were not part of the given specification. Exploring different ideas is great, but when working with a specification, it’s important to stay within its requirements. Can you update your code to include what the spec asks for?
The PR description is not yet properly written in Markdown syntax. Can you look up Markdown syntax for headers and checked checkboxes, and update the PR description accordingly? Here is the original content of the PR template in Markdown.

If formatted properly, the PR description should look something like this:

Note: I hid the description in the Changelist section.

github-actions · 2025-10-03T11:31:26Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-03T11:31:26Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-03T11:31:27Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-03T11:31:33Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-03T11:31:36Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

github-actions · 2025-10-03T11:36:07Z

Your PR description contained template fields which weren't filled in.

Check you've ticked everything in the self checklist, and that any sections which prompt you to fill in an answer are either filled in or removed.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

MohammedNaru · 2025-10-03T11:42:57Z

I have made the necessary changes, please can you review

cjyuan

Good job in keeping the branch clean and the PR description properly formatted.

Just some minor changes needed.

The top-most header in the PR description is not quite formatted correctly in Markdown.

cjyuan · 2025-10-03T12:34:54Z

Form-Controls/index.html

+      <label for="password">Password:</label>
+      <input type="password" id="password" name="password" required minlength="6" placeholder="Min 6 characters">
+


Does the spec ask for password input?

Can you remove all input elements that are not specified in the spec (README.md) from this form?

cjyuan · 2025-10-03T12:39:37Z

Form-Controls/index.html

+  <footer>
+    <p>Form Controls Project – Onboarding Module</p>
+  </footer>


The original HTML code has a comment that specifies what the footer content should be. Can you update the footer content to meet that requirement?

MohammedNaru · 2025-10-03T20:23:30Z

Good job in keeping the branch clean and the PR description properly formatted.

Just some minor changes needed.

The top-most header in the PR description is not quite formatted correctly in Markdown.

Update Please review again.

cjyuan · 2025-10-03T20:27:19Z

There are still quite some input elements on the form that are not specified in the spec. Password was just one of them. Can you remove all input elements that are not specified in the spec?

MohammedNaru · 2025-10-03T23:21:21Z

There are still quite some input elements on the form that are not specified in the spec. Password was just one of them. Can you remove all input elements that are not specified in the spec?

Updated, please review

…emoving unused fields

cjyuan

It's a best practice to keep a branch clean so that reviewers can focus on related changes.
Keeping unused code in comment can still make code review difficult. Can you keep your code as clean as possible?
The spec has a "No CSS" requirement. The code in the style attributes are still CSS.
You can keep the CSS code, but can you suggest a solution that does not involve using any CSS so that the page can still score 100 in Lighthouse accessibility?

cjyuan · 2025-10-03T23:32:06Z

Form-Controls/index.html

+        <label class="checkbox" style="display: block; margin-bottom: 16px; padding: 8px 0;">
+          <input type="checkbox" name="agree" required style="width: 24px; height: 24px; vertical-align: middle; margin-right: 8px;" />
+          Place Order
+        </label>


What is the use of this checkbox?

cjyuan · 2025-10-04T17:23:31Z

Everything looks great now. A clean and professional code and PR. Well done!

MohammedNaru added 2 commits October 1, 2025 16:37

Create Index.html

f117fb3

Create Style.css

ca525c5

MohammedNaru added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 1, 2025

MohammedNaru mentioned this pull request Oct 1, 2025

ITP-Sept-2025 | Onboarding | Ali Naru MohammedNaru/Coursework-Planner#35

Open

MohammedNaru added 2 commits October 2, 2025 21:06

Merge branch 'CodeYourFuture:main' into Form-Controls

64c3817

Refactored Form-Controls, Removed CSS

c091077

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025

Remove Index.html and Style.css files

20c2a28

MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 3, 2025

cjyuan reviewed Oct 3, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025

MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025

Refactor index.html for improved structure and accessibility

635d6ab

MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 3, 2025

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025

Update form title and Removed checkbox to meet criteria

c2e82c3

MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 3, 2025

Refactor form layout and improve accessibility by adding styles and r…

9fee712

…emoving unused fields

cjyuan reviewed Oct 3, 2025

View reviewed changes

cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 3, 2025

Removed Checkbox

1ed502d

MohammedNaru added Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. and removed Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 4, 2025

Refactor form elements for improved layout and accessibility

d39194b

cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Oct 4, 2025

		<label for="password">Password:</label>
		<input type="password" id="password" name="password" required minlength="6" placeholder="Min 6 characters">

Uh oh!

West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 2 | Form Controls #879

Are you sure you want to change the base?

West Midlands | ITP-Sept-2025 | Ali Naru | Sprint 2 | Form Controls #879

Uh oh!

Conversation

MohammedNaru commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Pull Request Form Controls

Changelist

Questions

Uh oh!

netlify bot commented Oct 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✅ Deploy Preview for cyf-onboarding-module ready!

Uh oh!

cjyuan commented Oct 1, 2025

Uh oh!

github-actions bot commented Oct 1, 2025

Uh oh!

cjyuan commented Oct 1, 2025

Uh oh!

cjyuan commented Oct 1, 2025

Uh oh!

MohammedNaru commented Oct 2, 2025

Uh oh!

cjyuan commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

github-actions bot commented Oct 3, 2025

Uh oh!

MohammedNaru commented Oct 3, 2025

Uh oh!

cjyuan left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

MohammedNaru commented Oct 3, 2025

Uh oh!

cjyuan commented Oct 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MohammedNaru commented Oct 3, 2025

Uh oh!

cjyuan left a comment

Choose a reason for hiding this comment

Uh oh!

cjyuan Oct 3, 2025

Choose a reason for hiding this comment

Uh oh!

cjyuan commented Oct 4, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

MohammedNaru commented Oct 1, 2025 •

edited

Loading

netlify bot commented Oct 1, 2025 •

edited

Loading

cjyuan left a comment •

edited

Loading

cjyuan commented Oct 3, 2025 •

edited

Loading