Skip to content

Manchester| 25-ITP-September| Jennifer Isidienu| Sprint 2 | Form Controls #899

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
JenniferIsidienu wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Manchester| 25-ITP-September| Jennifer Isidienu| Sprint 2 | Form Controls #899

JenniferIsidienu wants to merge 7 commits into from

Conversation

@JenniferIsidienu
Copy link

@JenniferIsidienu JenniferIsidienu commented Oct 6, 2025 •
edited
Loading

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

@netlify
Copy link

netlify bot commented Oct 6, 2025 •
edited
Loading

✅ Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 066a536
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/68e3b6774daab2000884fbe2
😎 Deploy Preview https://deploy-preview-899--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse		 2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 100 (🟢 up 14 from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

4 similar comments
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@JenniferIsidienu JenniferIsidienu added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Oct 6, 2025
@github-actions
Copy link

github-actions bot commented Oct 6, 2025

Your PR couldn't be matched to an assignment in this module.

Please check its title is in the correct format, and that you only have one PR per assignment.

If this PR is not coursework, please add the NotCoursework label (and message on Slack in #cyf-curriculum or it will probably not be noticed).

@JenniferIsidienu JenniferIsidienu changed the title Manchester| 25-ITP-September| Jennifer Isidienu| Sprint 1 | Form Controls Manchester| 25-ITP-September| Jennifer Isidienu| Sprint 2 | Form Controls Oct 6, 2025
CameronDowner
CameronDowner reviewed Oct 6, 2025
View reviewed changes
Copy link

@CameronDowner CameronDowner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking really good - I've left a couple of questions, but otherwise looking great 🙂

Form-Controls/index.html
</fieldset>

<fieldset>
<legend>Size <span aria-hidden="true">*</span></legend>
Copy link

@CameronDowner CameronDowner Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does aria-hidden do here?

Copy link
Author

@JenniferIsidienu JenniferIsidienu Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes the asterisk to only be seen and not read out...

Form-Controls/index.html
id="name"
required
minlength="2"
pattern=".*\S.*"
Copy link

@CameronDowner CameronDowner Oct 6, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is this pattern attribute doing here?

Copy link
Author

@JenniferIsidienu JenniferIsidienu Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It ensures the reader types in one character

Copy link

@CameronDowner CameronDowner Oct 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need this as well as minlength="2"?

Copy link
Author

@JenniferIsidienu JenniferIsidienu Oct 8, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minlength="2" only checks length, not content. Even if someone types two spaces, minlength="2" will accept it. The pattern ensures there’s at least one non-space character.

@CameronDowner CameronDowner added Reviewed Volunteer to add when completing a review with trainee action still to take. Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Oct 6, 2025
@CameronDowner
Copy link

CameronDowner commented Oct 8, 2025

Looking good 🙂 Marked as complete

@JenniferIsidienu JenniferIsidienu mentioned this pull request Oct 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@CameronDowner CameronDowner CameronDowner left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JenniferIsidienu @CameronDowner