Skip to content
This repository was archived by the owner on Aug 17, 2024. It is now read-only.

London9-Lovelace-Boshra-Mahmoudi-Node-Week2 #273

Open
BoshraM wants to merge 1 commit into
base: master
Choose a base branch
from
Open

London9-Lovelace-Boshra-Mahmoudi-Node-Week2 #273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 27 additions & 8 deletions index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,23 +4,42 @@
<title>Welcome to CYF Chat</title>
</head>
<body>
<h1>
<h1 id ="heading">
Copy link

@jackhclee jackhclee Apr 13, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the space between attribute name and equal operator

CYF Chat
</h1>
<h2>
Send a message
</h2>
<form action="/messages" method="post">
<form id="message-form">
<p>
Name: <input type="text" name="from" placeholder="Your Name" /> <br />
Message: <input type="text" name="text" placeholder="The message..." />
Name: <input type="text" name="from" placeholder="Your Name" id ="name-id" value =""/> <br />
Message: <input type="text" name="text" placeholder="The message..." id ="message-id" value =""/>
Comment on lines +15 to +16
Copy link

@jackhclee jackhclee Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name id attribute could be more meaningfully named in consistent manner. identifier-html control type The identifier could be the name attribute of the HTML control. so you may assign id attribute for the 1st input control as from-input and 2nd input control as text-input

<br />
</p>
<button type="submit">
<button type="submit" id = "send-id">
Send
</button>
</form>

<a href="/messages">See all messages</a>
</body>
</html>
<div style="display: flex; flex-direction: row;justify-content: space-evenly;" >

<div class="messages-containre" style="border:1px solid black">
<p>all the messages</p>
<div id="message-containre" >
Copy link

@jackhclee jackhclee Apr 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo containre vs container

</div>
</div>
<div class="latest-messages-containre" style="border: 1px black solid;">
<p>last 10 messages</p>
<button id="latest-button">Latest</button>
<div id="latest-message-containre" >
</div>
</div>
</div>

<!-- <a href="/messages">See all messages</a> -->


<script src="./script.js"></script>
</body>

</html>
Loading