Update the pd_skills endpoint. And altered the pd skills object. #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AliHaider-1
requested review from
Ade0211,
Denis-Andrei,
ISTANBULBEKLE,
osagiestar and
sadatakhtar
ISTANBULBEKLE
approved these changes
Nov 26, 2020
Contributor
ISTANBULBEKLE
left a comment
ISTANBULBEKLE
left a comment
There was a problem hiding this comment.
Good, job, guys, thanks
Denis-Andrei
suggested changes
Nov 26, 2020
| week3: null | ||
| }, | ||
|
|
||
| attended: { |
There was a problem hiding this comment.
The class attendance object should be like this:
,
classAttendance: {
'HTML/CSS': {
week1: 'yes',
week2: null,
week3: null
},
'JS Quizz 1': {
week1: null,
week2: 'no',
week3: null
},
'JavaScript 1': {
week1: null,
week2: null,
week3: null
},
'JavaScript 2': {
week1: null,
week2: null,
week3: null
},
'JavaScript 3': {
week1: null,
week2: null,
week3: null
}
}
Is no need for that attended:{
0: yes
1: no
3: late
}
Author
There was a problem hiding this comment.
Sadat has done these amendments in the next pull request.
sadatakhtar
approved these changes
Nov 26, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the pd_skills endpoint. And altered the pd skills object.