This repository was archived by the owner on Dec 5, 2023. It is now read-only.
Open
Conversation
added 5 commits
February 8, 2016 10:27
| frame.height = '1px'; | ||
| document.documentElement.appendChild(frame); | ||
| frame.parentNode.removeChild(frame); | ||
| if(window.__couiAndroid == undefined) { |
Member
There was a problem hiding this comment.
Please use space after keywords.
Member
|
Thanks for adding support for the newer Android WebView. |
Author
|
I fixed the code formatting. Hope it's ok now. Sorry it took so long, but I had a lot of work and forgot about this pull request... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems like the communication between javascript and WebView via iframe is no longer reliable on Android devices running WebView Version 47+. Therefore I created a direct communication between javascript and WebView using the JavaScriptInterface. To keep the compatibility with iOS, I added a check in coherent.js if the __couiAndroid-Interface is defined. If not, the script uses an iframe for communication (like it did before).
My changes are related to this thread in the forum:
https://forums.coherent-labs.com/index.php/topic,1061.0.html