Merged
Conversation
Described how to run the project and how to install the template or components.
README.md
Outdated
|
|
||
| The next steps are showing how to get started building the project using Gameface UI: | ||
|
|
||
| 1. Install `degit` globally with: `npm i -g degit`. |
Contributor
There was a problem hiding this comment.
Why not make them use npx?
Collaborator
Author
There was a problem hiding this comment.
Great idea. i will add both explanations - with npx and with npm.
Collaborator
Author
There was a problem hiding this comment.
Added note that you can use npx instead of installing globally degit
MartinBozhilov-coh
approved these changes
Nov 12, 2024
| @@ -0,0 +1,5 @@ | |||
| .Hud { | |||
| background-color: yellow; | |||
Collaborator
Author
There was a problem hiding this comment.
For testing purposes. We will change this when we develop the hud and menu views.
template/src/views/hud/index.tsx
Outdated
Comment on lines
8
to
10
| throw new Error( | ||
| 'Root element not found. Did you forget to add it to your index.html? Or maybe the id attribute got misspelled?', | ||
| ); |
Contributor
There was a problem hiding this comment.
We can remove that.
…so the gf-components are not throwing errors/warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://coherent-labs.atlassian.net/browse/COH-19981