added authentication#5
Closed
Eniola3321 wants to merge 1 commit intoColabFullstackClass:developfrom
Eniola3321:authController
Closed
added authentication#5Eniola3321 wants to merge 1 commit intoColabFullstackClass:developfrom Eniola3321:authController
Eniola3321 wants to merge 1 commit intoColabFullstackClass:developfrom
Eniola3321:authController
Conversation
Solomonsolomonsolomon
requested changes
Sep 14, 2025
|
|
||
| // 3) Validate password | ||
| const isMatch = await user.comparePassword(password, user.password); | ||
| console.log( |
Contributor
There was a problem hiding this comment.
remove console logs
| "outDir": "dist", | ||
| "esModuleInterop": true, | ||
| "allowSyntheticDefaultImports": true, | ||
| "forceConsistentCasingInFileNames": true, |
Contributor
There was a problem hiding this comment.
why did you make updates to the tsconfig
| subject: string; | ||
| message: string; | ||
| } | ||
| const sendEmail = async (options: EmailOptions) => { |
Contributor
There was a problem hiding this comment.
the env variables loaded should come from config and not directly
Contributor
There was a problem hiding this comment.
why did you delete the env example
| } from '../controllers/authController'; | ||
|
|
||
| const router: Router = Router(); | ||
| router.route('/signup').post(signUp); |
Contributor
There was a problem hiding this comment.
don't do it like this, use router.['insert any method there']
| //add all them routes here | ||
| app.use(rootRoutes); // this contains the routes localhost:port/ and localhost:port/health | ||
| app.use('/api', appRoutes); | ||
| app.use('/api/v1/users', userRouter); |
Contributor
There was a problem hiding this comment.
this isnt how it should be, it should just be /api
|
|
||
| // ---------------------- Informational Responses ---------------------- | ||
| export class Continue extends AppError { | ||
| constructor(message = 'Continue', statusCode = 100) { |
Contributor
There was a problem hiding this comment.
youre extending too many error codes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#closed