Skip to content

Update disk failed state to database #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
vinutha17 wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update disk failed state to database #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,7 +145,8 @@ fn check_for_failed_disks(
let mut dev_path = PathBuf::from("/dev");
let dev_name = state_machine.block_device.device.name.clone();

dev_path.push(state_machine.block_device.device.name);
// dev_path.push(state_machine.block_device.device.name);
Copy link
Collaborator

@cholcombe973 cholcombe973 Mar 19, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I would just remove this commented line and if you want you can change the line above to remove the .clone() like this:

                let dev_name = &state_machine.block_device.device.name;
                dev_path.push(&dev_name)

dev_path.push(&dev_name);

if state_machine.block_device.state == State::WaitingForReplacement {
description.push_str(&format!("\nDisk path: {}", dev_path.display()));
Expand Down Expand Up @@ -259,6 +260,7 @@ fn check_for_failed_disks(
}
// Handle the ones that ended up stuck in Fail
} else if state_machine.block_device.state == State::Fail {
save_state(pool,&state_machine.block_device, state_machine.block_device.state)?;
error!("Disk {} ended in a Fail state", dev_path.display(),);
} else {
// The rest should be State::Good ?
Expand Down