Open
Conversation
ersel
commented
Nov 14, 2020
| @@ -1,3 +1,18 @@ | |||
| const fizzBuzz = number => {}; | |||
| const fizzBuzz = number => { | |||
Author
There was a problem hiding this comment.
I try to avoid chaining ternaries as they get harder to read...
you could have considered if, or switch here.
ersel
commented
Nov 14, 2020
| // less verbose, more chained | ||
|
|
||
| const numberToReversedDigitsChain = number => { | ||
| return String(number).split("").map(char => Number(char)).reverse(); |
Author
There was a problem hiding this comment.
I would have done it like this, using chained...
ersel
commented
Nov 14, 2020
| @@ -1,3 +1,22 @@ | |||
| const humanCatDogYears = number => {}; | |||
| const calculateAnimalYears = (animal, number) => { | |||
| let factor = animal === "dog" ? 5 : animal === "cat" ? 4 : console.error("animal not recognised"); | |||
Author
There was a problem hiding this comment.
again, don't chain ternaries like this
ersel
commented
Nov 14, 2020
| const joinNames = namesObjArray => { | ||
| const names = namesObjArray.map((person, index) => { | ||
|
|
||
| if (index === namesObjArray.length - 1){ |
ersel
commented
Nov 14, 2020
Author
ersel
left a comment
ersel
left a comment
There was a problem hiding this comment.
just minor comments, nice clear solutions and descriptive variable names 👌
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.