-
Notifications
You must be signed in to change notification settings - Fork 1
Initial commit #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Initial commit #1
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General question about input and output types: should users paste raw byte strings?
We usually use file paths instead (input + output). We have a PDF merge task with this approach: https://github.com/FrendsPlatform/Frends.PDF/tree/main/Frends.Pdf.MergeDocuments
If confident with your approach, you can consider use `byte[][]' as input. Frends UI will treat List<byte[]> as one input, array will let users add multiple items.
Update namespace from Frends.Community.PDF to something more specific like Frends.Community.PdfMerge - including all directories, files, project metadata, and documentation.
Add workflow files. You can copy them from here: https://github.com/CommunityHiQ/Frends.Community.Multipart.SendMultipartRequest/tree/master/.github/workflows
just change the task name in a few places.
| public class Input | ||
| { | ||
| /// <summary> | ||
| /// Something that will be repeated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update XML comment: Change summary to "List of PDF files to merge" and example to show actual byte array usage.
| <PropertyGroup> | ||
| <TargetFramework>net8.0</TargetFramework> | ||
| <LangVersion>Latest</LangVersion> | ||
| <Version>0.0.1</Version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change version to 1.0.0
| <PackageTags>Frends</PackageTags> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <GenerateDocumentationFile>true</GenerateDocumentationFile> | ||
| <Description>Description of the Task</Description> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update description
| } | ||
|
|
||
| /// <summary> | ||
| /// Contains the input repeated the specified number of times. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Update XML comment, summary and example.
Added base code