fix(modules/inventory/server.lua): Fix Linter issues #59
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Safe Table Navigation from Lua Power Patches does not only breaks the linter, its also broken itself. Avoid using it Signed-off-by: Sergio <89666307+feelfreetofee@users.noreply.github.com>
Signed-off-by: Sergio <89666307+feelfreetofee@users.noreply.github.com>
Not when you made this PR, it was fixed in May/June 2025 with citizenfx/fivem@a2a71bd and a follow up fix for backwards compatibility with citizenfx/fivem@75f107c. It is perfectly fine to use Safe Navigation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safe Table Navigation from Lua Power Patches its not only broken, it also breaks the linter. Avoid using it.
I would also stop defining variables the following way:
local a, b = nil
Even if the variable b is nil too, VS does not like it and so do I