T2827 ADD support for multi-currency amounts in on-balance reconcilia…

[ecino]

…tion

[gemini-code-assist]

Summary of Changes

Hello @ecino, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request extends the on-balance reconciliation feature to fully support multi-currency transactions. It modifies core logic to track and distribute amounts in both the company's base currency and the transaction's foreign currency, ensuring accurate financial reporting and reconciliation for international operations. The changes include updates to amount calculation, move line creation, and comprehensive test coverage for multi-currency scenarios.

Highlights

• Multi-currency support: Implemented multi-currency handling for on-balance reconciliation, ensuring amounts are tracked in both company and transaction currencies.
• Updated _build_onbalance_amounts: This method now calculates and returns both company and foreign currency amounts for distribution, updating its return type to a tuple of (amount, amount_currency).
• Enhanced move line creation: The _create_onbalance_move_lines and _create_offbalance_asset_line methods were updated to correctly process and store amount_currency for new accounting entries, including currency assignment and rounding.
• New multi-currency test case: A dedicated test, test_direct_multicurrency_invoice, was added to validate the new multi-currency reconciliation logic, including currency rate setup and assertions on amount_currency values.
• Improved test helper: The _create_payment test helper now supports creating multi-currency payment entries by accepting currency and amounts_currency parameters.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds multi-currency support for on-balance reconciliation, which is a significant enhancement. The changes correctly propagate currency amounts through the reconciliation logic and include a new test case to validate this behavior. My review focuses on improving the robustness and clarity of the new multi-currency calculations. I've identified a potential issue with using an unsigned amount field and suggested refactoring a helper function for better readability and maintainability. I've also included a minor suggestion to follow Python best practices for better performance.