cancel payment lines when payment order is not accepted

[davidwul]

Restore functionnalities that were lost when community payment orders started to use the odoo standart account_payment object.

[gemini-code-assist]

Summary of Changes

Hello @davidwul, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request restores critical functionality for handling rejected payment orders within the Odoo system. It specifically addresses issues that arose when community payment orders began utilizing the standard account_payment object, ensuring that payment lines are correctly identified and canceled when a payment order is not accepted, thereby improving the robustness of the payment processing workflow.

Highlights

• Expanded Payment Order States: The logic for processing payment order cancellations now considers both "generated" and "uploaded" states, ensuring broader coverage for rejected payment orders.
• Updated Payment Line Identification: The method for linking rejected transactions to specific payment lines has been revised to align with the Odoo standard account_payment object, using payment_ids and move_id.id for accurate identification.
• Robust Payment Line Cancellation: The free_line operation is now applied individually to each relevant payment line within a loop, incorporating error handling to prevent failures during the cancellation process.
• Conditional State Transition: The generated2uploaded() method call is now conditional, only executing if the payment order is in the "generated" state, preventing unintended state changes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request restores functionality for canceling payment lines when a payment order is rejected, adapting the logic to work with standard Odoo account.payment objects. The changes correctly handle payment orders in both 'generated' and 'uploaded' states.

My review focuses on improving the robustness and correctness of the new logic for identifying and processing rejected payment lines. I've identified a critical issue in how payment lines are looked up, which could lead to errors or incorrect behavior. I've also suggested improvements to error handling and logging to make the process more resilient and easier to debug. Additionally, there's a minor style suggestion to improve code readability.