Skip to content

T2792 Ensure child protection on children page#2059

Merged
ecino merged 17 commits into14.0from
T2792]-Ensure-Child-Protection-on-Children-Page
Feb 12, 2026
Merged

T2792 Ensure child protection on children page#2059
ecino merged 17 commits into14.0from
T2792]-Ensure-Child-Protection-on-Children-Page

Conversation

@Shayan105
Copy link
Member

This PR is linked to this one : CompassionCH/compassion-website#211

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Shayan105, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances child protection by implementing a mechanism to obfuscate the precise geographical coordinates of projects. It introduces new data fields and logic to retrieve and store less precise location data, ensuring that sensitive information is not directly exposed while still providing a general sense of location. This change is crucial for maintaining privacy on public-facing pages, such as the children's page.

Highlights

  • New Obfuscated Coordinate Fields: Two new fields, gps_latitude_obfuscated and gps_longitude_obfuscated, have been added to the CompassionProject model to store privacy-preserving location data.
  • Google Maps Geocoding Integration: A new method update_obfuscated_coordinates was introduced to fetch and store obfuscated coordinates for projects using the Google Maps Geocoding API, ensuring an API key is configured before making requests.
  • Safe Coordinate Exposure: A get_obfuscated_coordinates_json method has been added to provide obfuscated coordinates in JSON format. If obfuscated coordinates are not available, it falls back to returning the integer part of the real coordinates for a rough, non-precise location.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@Shayan105 Shayan105 changed the title T2792] ensure child protection on children page T2792 Ensure child protection on children page Nov 27, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a feature to obfuscate project coordinates to enhance child protection, which is a great initiative. The implementation involves adding new fields and a method to fetch obfuscated coordinates from the Google Geocoding API. While the overall approach is sound, I've identified a critical bug in the fallback logic for coordinates, which could lead to incorrect location data being sent. Additionally, there are several opportunities to improve the robustness and performance of the external API communication, such as adding timeouts, handling exceptions more specifically, and considering the performance impact of making API calls in a loop. Addressing these points will make the feature more reliable and resilient.

@ecino ecino changed the base branch from 14.0-MyCompassion2 to 14.0 February 5, 2026 10:33
@ecino ecino force-pushed the T2792]-Ensure-Child-Protection-on-Children-Page branch from 55d3781 to ee0ada6 Compare February 12, 2026 13:10
@ecino ecino force-pushed the T2792]-Ensure-Child-Protection-on-Children-Page branch from ee0ada6 to ae6350c Compare February 12, 2026 13:28
@ecino ecino merged commit 77addb3 into 14.0 Feb 12, 2026
1 check passed
@ecino ecino deleted the T2792]-Ensure-Child-Protection-on-Children-Page branch February 12, 2026 13:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants