T2987 original language new letters

[Danielgergely]

• FIX: When creating the generator, the detected language id is passed on to the constructor
• FIX: Added alt text to the template images

[gemini-code-assist]

Summary of Changes

Hello @Danielgergely, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses two key areas: improving data accuracy and enhancing accessibility. It introduces automatic language detection for new letter content, ensuring that the correct language is recorded, and adds descriptive alternative text to template images, making the user interface more accessible.

Highlights

• Language Detection for Letters: Implemented automatic language detection for the letter_body when creating new letters, ensuring the correct language ID is associated. If no language is detected, it defaults to English.
• Image Accessibility: Enhanced accessibility by adding alt text to template images in the new letter creation page, using the template's name as the descriptive text.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• my_compassion/controllers/my2_letters.py
  • Introduced logic to detect the language of the letter body.
  • Assigned the detected language ID to the letter_values dictionary.
  • Defaulted to English language ID if no language is detected.
• my_compassion/templates/pages/my2_new_letter.xml
  • Added t-att-alt attribute to template-image elements, setting its value to template.name.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request introduces two fixes: language detection for new letters and adding alt text for template images to improve accessibility. The changes are good, but I've found a potential issue in the language detection fallback logic. Accessing .id on a search result without checking if a record was found can lead to an AttributeError if the default English language is not found. I've suggested a change to prevent a server crash in this scenario.

[ecino]

Does this work for all user types? Maybe sudo() will ensure everyone has the rights. But shouldn't this logic happen at a higher level for every kind of S2B correspondence creation ?

Suggested change

	detected_lang = request.env["langdetect"].detect_language(body_text)
	detected_lang = request.env["langdetect"].sudo().detect_language(body_text)