Skip to content

T2903 center settings data page content#285

Open
Danielgergely wants to merge 2 commits into14.0from
T2903-center-settings-data-page-content
Open

T2903 center settings data page content#285
Danielgergely wants to merge 2 commits into14.0from
T2903-center-settings-data-page-content

Conversation

@Danielgergely
Copy link
Member

FIX: buttons, texts and links on the data & privacy protection page are all centered

image SCR-20260217-hqgu

- FIX: the child protection charter title is now centered
- FIX: buttons, texts and links on the data & privacy protection page are all centered
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @Danielgergely, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the user interface of the data and privacy protection settings page by centralizing various content elements. The changes ensure a more balanced and visually appealing layout for buttons, text, and links within the 'Child protection charter' and 'Data protection and legal agreement' sections, improving overall readability and aesthetic consistency.

Highlights

  • Child Protection Charter Section Styling: Applied the 'text-center' class to the main content block of the 'Child protection charter' section to center its text.
  • Child Protection Charter Button Centering: Added the 'm-auto' class to the button container within the 'Child protection charter' section to horizontally center the button.
  • Data Protection and Legal Agreement Section Styling: Applied 'd-flex flex-column text-center' classes to the main content block of the 'Data protection and legal agreement' section to center its text and align items.
  • Data Protection and Legal Agreement Link and Button Centering: Wrapped the signing date and agreement link in a flex container with 'justify-content-center' to center them, and added 'm-auto' to the button container to center the button.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • my_compassion/templates/pages/my2_user_settings.xml
    • Added 'text-center' class to a div containing the 'Child protection charter' section.
    • Applied 'm-auto' class to a div wrapping a button within the 'Child protection charter' section.
    • Added 'd-flex flex-column text-center' classes to a div containing the 'Data protection and legal agreement' section.
    • Introduced a new div with 'd-flex justify-content-center' to wrap the signing date and agreement link, and added 'mr-2' for spacing.
    • Applied 'm-auto' class to a div wrapping a button within the 'Data protection and legal agreement' section.
Activity
  • No activity has occurred yet since the pull request was created.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request centers content on the data and privacy protection page using Bootstrap utility classes. The changes are generally correct, but I've identified a couple of areas where the flexbox alignment could be made more robust and idiomatic. My suggestions focus on using align-items-center for horizontal centering within flex columns to ensure consistent and clear behavior.

</div>
</div>
<div class="d-flex flex-column justify-content-center mb-5">
<div class="d-flex flex-column justify-content-center mb-5 text-center">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For a flex-column container, justify-content-center handles vertical alignment. For horizontal centering of block-level items like the <h5> and the button's container, align-items-center is the correct utility. Using it here would make the centering logic clearer and more robust, which is the goal of this pull request.

Suggested change
<div class="d-flex flex-column justify-content-center mb-5 text-center">
<div class="d-flex flex-column align-items-center mb-5 text-center">

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant