Update TLS endpoints to use OpenShift API server configuration #1000
Conversation
We have a results server that exposes a TLS 1.2 endpoint. This is fine today, but pulling this from a more authoritative source, like the OpenShift API server is better because then a user can configure it in a single place and have the change propagate to the Compliance Operator automatically. This commit updates the operator to use the OpenShift API server TLS configuration, instead of hard-coding it to TLS 1.2. If the operator encounters issues fetching the API server configuration, it defaults back to TLS 1.2. Assisted-By: Claude
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
🤖 To deploy this PR, run the following command: |
|
@rhmdnd: The following test failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
|
We'll need a way to test this in conjunction with the API server so that we know it's working as expected. |
| @@ -0,0 +1,168 @@ | |||
| package utils | |||
There was a problem hiding this comment.
Instead of building another utility by hand, we should strongly consider using the existing library-go utilities.
We have a results server that exposes a TLS 1.2 endpoint. This is fine
today, but pulling this from a more authoritative source, like the
OpenShift API server is better because then a user can configure it in a
single place and have the change propagate to the Compliance Operator
automatically.
This commit updates the operator to use the OpenShift API server TLS
configuration, instead of hard-coding it to TLS 1.2. If the operator
encounters issues fetching the API server configuration, it defaults
back to TLS 1.2.
Assisted-By: Claude