-
Notifications
You must be signed in to change notification settings - Fork 36
Use content built from Konflux instead of ghcr #1019
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Use content built from Konflux instead of ghcr #1019
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rhmdnd The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
We're already using Konflux to build the content, so let's update the e2e testing to also use that content instead of referencing the old k8scontent github action.
4b59ee7 to
ba7331c
Compare
|
🤖 To deploy this PR, run the following command: |
|
🤖 To deploy this PR, run the following command: |
yuumasato
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure if it will help with the current failures on:
=== NAME TestNonExistentDeprecatedProfile
main_test.go:786: expected error message to be from failed profile deprecation check
--- FAIL: TestNonExistentDeprecatedProfile (25.04s)
But I think images/testcontent/Dockerfile.ci needs to be updated as well, as it uses the testcontent as CONTENT_IMAGE_FROM_CI:
https://github.com/openshift/release/blob/master/ci-operator/config/ComplianceAsCode/compliance-operator/ComplianceAsCode-compliance-operator-master.yaml#L35
|
/retest |
2 similar comments
|
/retest |
|
/retest |
|
@rhmdnd: The following tests failed, say
Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
We're already using Konflux to build the content, so let's update the
e2e testing to also use that content instead of referencing the old
k8scontent github action.