Skip to content

Conversation

@Anna-Koudelkova
Copy link
Collaborator

@Anna-Koudelkova Anna-Koudelkova commented Jan 16, 2026

…SelectorFiltersCorrectly

This PR covers the second checkpoint from OCP-41093 - the check if the node name appears in target & fact:identifier elements of complianceScan XCCDF format result.

In this case we are just checking if it is true for selected worker nodes, the original test case is also checking it for master nodes. If the check for master nodes is necessary as well, it is possible to glue this to serial test cases TestSuiteScan or TestSuiteScanHasCheckCounts instead.

Currently the test case is passing on OCP 4.21 cluster:

2026/01/16 15:17:08 ComplianceScan ready (DONE)
--- PASS: TestScanWithNodeSelectorFiltersCorrectly (61.12s)
PASS
... 
ok  	github.com/ComplianceAsCode/compliance-operator/tests/e2e/parallel	247.452s

Assisted-by: Cursor

@openshift-ci-robot
Copy link
Collaborator

@Anna-Koudelkova: This pull request references CMP-3813 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.22.0" version, but no target version was set.

Details

In response to this:

…SelectorFiltersCorrectly

This PR covers the second checkpoint from OCP-41093 - check if the node name appears in target & fact:identifier elements of complianceScan XCCDF format result. Currently WIP

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: Anna-Koudelkova

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci
Copy link

openshift-ci bot commented Jan 16, 2026

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@github-actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1052-b18b9d350e1e2b9d0a1eee40779ebd731bb0b923

@github-actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1052-76d4ce31a1307a12da8b283db8c977ca4321bbdb

@github-actions
Copy link

🤖 To deploy this PR, run the following command:

make catalog-deploy CATALOG_IMG=ghcr.io/complianceascode/compliance-operator-catalog:1052-2d650c7acd4964d08f62b9d952973b1453988940

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants