Skip to content

Optimize BFGS for spinel#2

Open
albert-de-montserrat wants to merge 3 commits intoComputationalThermodynamics:mainfrom
albert-de-montserrat:adm/opt_spinel_BFGS
Open

Optimize BFGS for spinel#2
albert-de-montserrat wants to merge 3 commits intoComputationalThermodynamics:mainfrom
albert-de-montserrat:adm/opt_spinel_BFGS

Conversation

@albert-de-montserrat
Copy link

Optimizes BFGS for the spinel case. I see a speed up of ~30/40% on my machine.

Main branch:

julia> @be null_min_BFGS!($gv,$ph,$gm)
Benchmark: 3173 samples with 22 evaluations
 min    1.291 μs
 median 1.305 μs
 mean   1.310 μs
 max    2.350 μs

This PR:

julia> @be null_min_BFGS!($gv,$ph,$gm)
Benchmark: 2762 samples with 33 evaluations
 min    872.727 ns
 median 881.818 ns
 mean   884.147 ns
 max    1.621 μs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant