feat: add keyboard shortcuts to browser extension for ruler and mask#155
Open
jonahhb wants to merge 1 commit intoContentSquare:masterfrom
Open
feat: add keyboard shortcuts to browser extension for ruler and mask#155jonahhb wants to merge 1 commit intoContentSquare:masterfrom
jonahhb wants to merge 1 commit intoContentSquare:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added keyboard shortcuts that activate/deactivate the mask and ruler on browser extensions as requested in #44.
The shortcuts are:
Ruler: CTRL+ALT+R
Mask: CTRL+ALT+N (not m because of a conflict)
I have tested the functionality on Chrome and Firefox and it works as expected. I do not own a Mac to test Safari.
All tests pass locally and in GitHub Actions. I did not contribute to any linter warnings.