Add pull-up resistor control

[glenndrives]

Adding this functionality to the official firmware will expose the input pin pull-up resistor control to all users. It will make my life a lot easier too.
I'll be more than happy to do this for the other relay controllers as well.

Thanks for taking a look, Glenn.

[telliottosceola]

Hey Glen,
Thanks for the pull request. I am thinking a whole initialization function should be added to the library(replacing the setAddress function). The function would allow the user to set the I2C address of the chip, the IO direction of the 6 spare IOs on the 2 relay boards and also pull inputs high or let them float. What do you think?

[glenndrives]

I was thinking the same thing but just fixed what I need in the short term. I can do the rest if you like. Glenn Glenn L. Hickman Jr. WHRO 5200 Hampton Boulevard | Norfolk, VA 23508 P: 757.575.5064<tel:757.575.5064> | F: 757.489.0007<tel:757.489.0007> glennh@whro.org<mailto:glennh@whro.org> whro.org<http://whro.org>

…

-------- Original message -------- From: telliottosceola <notifications@github.com> Date: 8/7/17 09:56 (GMT-05:00) To: ControlEverythingCom/NCD2Relay <NCD2Relay@noreply.github.com> Cc: Glenn Hickman <Glenn.Hickman@whro.org>, Author <author@noreply.github.com> Subject: Re: [ControlEverythingCom/NCD2Relay] Add pull-up resistor control (#3) Hey Glen, Thanks for the pull request. I am thinking a whole initialization function should be added to the library(replacing the setAddress function). The function would allow the user to set the I2C address of the chip, the IO direction of the 6 spare IOs on the 2 relay boards and also pull inputs high or let them float. What do you think? — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGmbkFJ5zyqGioudDBb1FCUOqi6GRKhUks5sVxeMgaJpZM4Or1I9>.

[glenndrives]

Thinking about this, if we replace setAddress with, say, setInit ... won't this break compatibility with any current firmware users? Why not leave setAddress and add setInit with control of all the other config stuff?

[telliottosceola]

Hi Glen, Yes, that could certainly be done as well. I just worry about setAddress setting those pull ups and IO directions, it really has to be called first, and then setIODirection and setPullUps Travis Elliott National Control Devices 430 Market St Osceola Mo 64776 417 646 5644 travis@controlanything.com

…

On Aug 7, 2017, at 9:50 AM, Glenn Hickman ***@***.***> wrote: Thinking about this, if we replace setAddress with, say, setInit ... won't this break compatibility with any current firmware users? Why not leave setAddress and add setInit with control of all the other config stuff? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHSCEDVWn2hQ4XYs1bSj9EsrBNTA1Nwkks5sVyQ2gaJpZM4Or1I9>.

[glenndrives]

I'll code it up and send it on for your approval. Glenn L. Hickman Jr. WHRO 5200 Hampton Boulevard | Norfolk, VA 23508 P: 757.575.5064<tel:757.575.5064> | F: 757.489.0007<tel:757.489.0007> glennh@whro.org<mailto:glennh@whro.org> whro.org<http://whro.org>

-------- Original message -------- From: telliottosceola <notifications@github.com> Date: 8/7/17 14:13 (GMT-05:00) To: ControlEverythingCom/NCD2Relay <NCD2Relay@noreply.github.com> Cc: Glenn Hickman <Glenn.Hickman@whro.org>, Author <author@noreply.github.com> Subject: Re: [ControlEverythingCom/NCD2Relay] Add pull-up resistor control (#3) Hi Glen, Yes, that could certainly be done as well. I just worry about setAddress setting those pull ups and IO directions, it really has to be called first, and then setIODirection and setPullUps Travis Elliott National Control Devices 430 Market St Osceola Mo 64776 417 646 5644 travis@controlanything.com

On Aug 7, 2017, at 9:50 AM, Glenn Hickman ***@***.***> wrote: Thinking about this, if we replace setAddress with, say, setInit ... won't this break compatibility with any current firmware users? Why not leave setAddress and add setInit with control of all the other config stuff? — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#3 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AHSCEDVWn2hQ4XYs1bSj9EsrBNTA1Nwkks5sVyQ2gaJpZM4Or1I9>.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub<#3 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AGmbkEAyUcr2lARCYruHAyPvR6KvUsvpks5sV1PCgaJpZM4Or1I9>.