Skip to content

core/vm: avoid escape to heap #2618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ucwong merged 1 commit into from
Jan 10, 2026
Merged

core/vm: avoid escape to heap #2618

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions core/vm/contracts.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,11 +271,13 @@ func (c *ecrecover) Run(input []byte) ([]byte, error) {
if bitutil.TestBytes(input[32:63]) || !crypto.ValidateSignatureValues(v, r, s, false) {
return nil, nil
}
sig := make([]byte, 65)
copy(sig, input[64:128])
// We must make sure not to modify the 'input', so placing the 'v' along with
// the signature needs to be done on a new allocation
var sig [65]byte
copy(sig[:], input[64:128])
sig[64] = v
// v needs to be at the end for libsecp256k1
pubKey, err := crypto.Ecrecover(input[:32], sig)
pubKey, err := crypto.Ecrecover(input[:32], sig[:])
// make sure the public key is a valid one
if err != nil {
return nil, nil
Expand Down